Bug #80978 for Text-Sass: & includes don't work in nested blocks

Thu Nov 08 14:34:06 2012 bgrimm [...] cpan.org - Ticket created

Subject:

& includes don't work in nested blocks

in _stash2css: if($k =~ /&/smx) { ($vk) = $k =~ /&(.*)$/smx; should be if($k =~ /&/smx) { $vk = $k; $vk =~ s/(?:[^\s]+\s+)?&//smx; in order to maintain the name of the parent name(s)

Thu Nov 08 14:51:04 2012 rmp [...] psyphi.net - Status changed from 'new' to 'open'

Thu Nov 08 14:51:38 2012 rmp [...] psyphi.net - Correspondence added

Could you post a brief test input+output for this one please and i'll add it to the regressions - thanks.

Thu Nov 08 14:56:42 2012 bgrimm [...] cpan.org - Correspondence added

Sorry, I forgot to include the example: a { b { &.this { color: #fff; } } } without the fix I provided renders as: b.this { color: #ffffff; } rather than: a b.this { color: #ffffff; }

Thu Nov 08 15:14:25 2012 bengrimm [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #80978] AutoReply: & includes don't work in nested blocks
Date:	Thu, 8 Nov 2012 13:52:30 -0600
To:	bug-Text-Sass [...] rt.cpan.org
From:	Ben Grimm <bengrimm [...] gmail.com>

I didn't provide an example: a { b { &.this { color: #fff; } } } without the fix I provided that renders as: b.this { color: #ffffff; } rather than: a b.this { color: #ffffff; } On Thu, Nov 8, 2012 at 1:34 PM, Bugs in Text-Sass via RT < bug-Text-Sass@rt.cpan.org> wrote: Show quoted text

> > Greetings, > > This message has been automatically generated in response to the > creation of a trouble ticket regarding: > "& includes don't work in nested blocks", > a summary of which appears below. > > There is no need to reply to this message right now. Your ticket has been > assigned an ID of [rt.cpan.org #80978]. Your ticket is accessible > on the web at: > > https://rt.cpan.org/Ticket/Display.html?id=80978 > > Please include the string: > > [rt.cpan.org #80978] > > in the subject line of all future correspondence about this issue. To do > so, > you may reply to this message. > > Thank you, > bug-Text-Sass@rt.cpan.org > > ------------------------------------------------------------------------- > > in _stash2css: > > if($k =~ /&/smx) { > ($vk) = $k =~ /&(.*)$/smx; > > should be > > if($k =~ /&/smx) { > $vk = $k; > $vk =~ s/(?:[^\s]+\s+)?&//smx; > > in order to maintain the name of the parent name(s) > > >

Thu Nov 08 16:11:51 2012 rmp [...] psyphi.net - Correspondence added

Thanks very much for that. I've made a .t with your example which obviously passes, but a couple of the 90-regression- wikipedia*t files now fail. I'll have a poke around. Text::Sass isn't the easiest module to modify/maintain! :)

Sat Nov 10 11:35:36 2012 rmp [...] psyphi.net - Correspondence added

Still having issues debugging this one, but I've packaged and released Text::Sass 0.97 with the other two patches in. I added t/RT-80978-nested-ampersand-includes.t, skipped, if you're interested in having a play.

Mon Nov 12 11:41:36 2012 bgrimm [...] cpan.org - Correspondence added

So then, it looks like the _stash2css code is right when processing sass -- but fails when processing scss. I wonder if it would be better to break that sub into two separate handlers. On Sat Nov 10 11:35:36 2012, RPETTETT wrote: Show quoted text

> Still having issues debugging this one, but I've packaged and released > Text::Sass 0.97 with the > other two patches in. > > I added t/RT-80978-nested-ampersand-includes.t, skipped, if you're > interested in having a > play.

Mon Jun 26 12:37:30 2017 rmp [...] psyphi.net - Taken