Bug #80705 for DBIx-Class-InflateColumn-Object-Enum: Problem with $row->update()

Thu Nov 08 09:28:58 2012 http://a-toy.eu/ - Ticket created

Subject:

Problem with $row->update()

hello, When i update a row, i've to force the column as "dirty". example : $row = $rs->find($id); $row->myenumcolumn->is_bar; # true $row->myenumcolumn->set_foo(); $row->update(); Doesn't work, DBIx::Class doesn't detect any changes, but this one works : $row->myenumcolumn->set_foo(); $row->make_column_dirty('myenumcolumn'); $row->update(); Thanks Anthony.

Mon Aug 05 11:12:23 2013 DAVEWOOD [...] cpan.org - Correspondence added

I am just here to say this bug is still there.

Mon Aug 05 11:12:23 2013 The RT System itself - Status changed from 'new' to 'open'

Thu Feb 27 19:23:21 2014 jmmills [...] cpan.org - Taken

Fri Feb 28 21:02:27 2014 jmmills [...] cpan.org - Correspondence added

I've created a test for this and confirmed it. I'm working the ticket, worst case scenario is that I'll have to force the column to be dirty any time it inflates. The systemic problem however is "Does DBIC know when a column is an object changes state?"

Mon May 12 16:59:49 2014 rt-cpan [...] trout.me.uk - Correspondence added

On Fri Feb 28 21:02:27 2014, JMMILLS wrote: Show quoted text

> I've created a test for this and confirmed it. > I'm working the ticket, worst case scenario is that I'll have to force > the column to be dirty any time it inflates. > The systemic problem however is "Does DBIC know when a column is an > object changes state?"

This isn't a bug. It merely indicates that as a stateful object, Object::Enum is the wrong thing to inflate enums to. If you had a proper Value Object of some sort, then you'd be doing $row->enum_column($new_enum_value); which would be detected correctly.

Mon May 12 18:08:45 2014 jmmills [...] cpan.org - Correspondence added

Okay, after some discussion with mst on this matter - it seems that the real issue is that Object::Enum should be immutable in this instance. Here is a paste of the conversation https://gist.github.com/jmmills/c4dec6ade536db877db6 My process on this ticket will be thus: * Get immutability added to Object::Enum upstream (likely sans $obj->set_$value methods) * Update this inflator class to use that behavior by default. On Thu Nov 08 09:28:58 2012, http://a-toy.eu/ wrote: Show quoted text

> hello, > > When i update a row, i've to force the column as "dirty". > > example : > > $row = $rs->find($id); > > $row->myenumcolumn->is_bar; # true > > $row->myenumcolumn->set_foo(); > $row->update(); > > Doesn't work, DBIx::Class doesn't detect any changes, but this one works > : > > $row->myenumcolumn->set_foo(); > $row->make_column_dirty('myenumcolumn'); > $row->update(); > > Thanks > Anthony.