Bug #80681 for Finance-MtGox: Make header safe when using with clients other than LWP/Mech

Base64 decoders typically ignore unknown characters (like whitespace). It should be safe to just strip them out since that's what the LWP module has been doing anyway. Additionally MIME::Base64::encode_base64() accepts an eol character as the second parameter (which defaults to "\n"). So you could pass an empty string as the second parameter to get the same effect (as is stated in the docs). I have attached a patch with a small test file to demonstrate. I don't know much about the module though so adjust as necessary.

diff --git a/lib/Finance/MtGox.pm b/lib/Finance/MtGox.pm index f58a4f1..5aea402 100644 --- a/lib/Finance/MtGox.pm +++ b/lib/Finance/MtGox.pm @@ -309,7 +309,7 @@ sub _generate_nonce { sub _sign { my ( $self, $message ) = @_; my $secret = decode_base64( $self->_secret ); - return encode_base64( hmac_sha512( $message, $secret ) ); + return encode_base64( hmac_sha512( $message, $secret ), '' ); } =head1 AUTHOR diff --git a/t/http-request.t b/t/http-request.t index e69de29..1a32f17 100644 --- a/t/http-request.t +++ b/t/http-request.t @@ -0,0 +1,25 @@ +use strict; +use warnings; + +use Finance::MtGox; +use Test::More tests => 6; + +my $key = 'K'; +my $secret = 'S'; +my $mtgox = Finance::MtGox->new({ + key => $key, + secret => $secret, +}); +ok( $mtgox, 'Finance::MtGox object created' ); + +my $req = $mtgox->_build_api_method_request('POST', 'N', 'P'); + +like $req->uri, qr{https://mtgox\.com/api/0/P/N\.php}, 'uri'; + +like $req->content, qr/nonce=\d+/, 'nonce'; + +is $req->header('content-type'), 'application/x-www-form-urlencoded', 'content-type'; + +is $req->header('rest-key'), 'K', 'rest-key header'; + +unlike $req->header('rest-sign'), qr/\n/, 'no newlines in header';