Bug #8068 for Net-Radius: support for Tagged Attribute , fixes and cleanups

Wed Oct 20 13:29:40 2004 Guest - Ticket created

Subject:

support for Tagged Attribute , fixes and cleanups

Hi, I use the Net-Radius-1.44 with a test environment and found some Bugs i add the Support for Tagged Attributes, RFC3576 Disconnect Disconnect-ACK/NAK, CoA-Request CoA-ACK/NAK and ROCP Info-Request/Response to the Library The Patch i add suggest to patch it to version 1.45 it will be great if you would accept the patch and make it a release ! thanx chris

Message body is not shown because it is too large.

Wed Oct 20 21:50:00 2004 luismunoz [...] cpan.org - Taken

Wed Oct 20 21:51:06 2004 luismunoz [...] cpan.org - Correspondence added

[guest - Wed Oct 20 13:29:40 2004]: Show quoted text

> Hi, > I use the Net-Radius-1.44 with a test environment and found some Bugs > > i add the Support for Tagged Attributes, RFC3576 Disconnect > Disconnect-ACK/NAK, CoA-Request CoA-ACK/NAK and ROCP Info- > Request/Response > to the Library > > The Patch i add suggest to patch it to version 1.45 > it will be great if you would accept the patch and make it a release ! > > thanx > chris

Hi Chris and thanks for the heads up and the patch. I'll be adding it to the next release. I will not close this ticket just yet. I will update when ready to upload. Best regards. -lem

Wed Oct 20 21:52:05 2004 luismunoz [...] cpan.org - Status changed from 'new' to 'open'

Wed Apr 19 10:59:03 2006 Guest - Correspondence added

From:

eddie [...] saix.net

On Wed Oct 20 21:51:06 2004, LUISMUNOZ wrote: Show quoted text

> [guest - Wed Oct 20 13:29:40 2004]: >

> > Hi, > > I use the Net-Radius-1.44 with a test environment and found some

> Bugs

> > > > i add the Support for Tagged Attributes, RFC3576 Disconnect > > Disconnect-ACK/NAK, CoA-Request CoA-ACK/NAK and ROCP Info- > > Request/Response > > to the Library > > > > The Patch i add suggest to patch it to version 1.45 > > it will be great if you would accept the patch and make it a release

> !

> > > > thanx > > chris

> > Hi Chris and thanks for the heads up and the patch. I'll be adding it > to the next release. > > I will not close this ticket just yet. I will update when ready to > upload. > > Best regards. > > -lem > >

It seems this issue has been outstanding for at least 18 months or so. Is this module still being maintained? I would like to see at least the support for RFC3576 packet types added so I don't have to run my own patched version. The patch is trivial and should not affect any current functionality. Thanks, Eddie

Wed Apr 19 11:06:22 2006 lem [...] cantv.net - Correspondence added

Subject:	Re: [rt.cpan.org #8068] support for Tagged Attribute , fixes and cleanups
Date:	Wed, 19 Apr 2006 11:05:19 -0400
To:	bug-Net-Radius [...] rt.cpan.org
From:	Luis Muñoz <lem [...] cantv.net>

On Apr 19, 2006, at 10:59 AM, Guest via RT wrote: Show quoted text

> > Queue: Net-Radius > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=8068 >

Show quoted text

> It seems this issue has been outstanding for at least 18 months or so. > Is this module still being maintained? I would like to see at least > the > support for RFC3576 packet types added so I don't have to run my own > patched version. The patch is trivial and should not affect any > current > functionality.

Hi Eddie Yes, the module is still maintained. Unfortunately, I haven't had the time to put together a new release yet. I'm currently working on a new release of NetAddr::IP. Net::Radius will come next. At such time, patches will be added to the distribution, along with proper credits. Regards. -lem

Thu Apr 20 07:03:05 2006 Guest - Correspondence added

On Wed Apr 19 11:06:22 2006, lem@cantv.net wrote: Show quoted text

> > On Apr 19, 2006, at 10:59 AM, Guest via RT wrote: >

> > > > Queue: Net-Radius > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=8068 >

>

> > It seems this issue has been outstanding for at least 18 months or so. > > Is this module still being maintained? I would like to see at least > > the > > support for RFC3576 packet types added so I don't have to run my own > > patched version. The patch is trivial and should not affect any > > current > > functionality.

> > Hi Eddie > > Yes, the module is still maintained. Unfortunately, I haven't had the > time to put together a new release yet. I'm currently working on a new > release of NetAddr::IP. Net::Radius will come next. > > At such time, patches will be added to the distribution, along with > proper credits. > > Regards. > > -lem > > >

Thanks for the reply, I'll keep an eye open for the new release. Regards, Eddie

Sat Oct 21 09:48:03 2006 polettix [...] cpan.org - Correspondence added

Show quoted text

> Yes, the module is still maintained. Unfortunately, I haven't had the > time to put together a new release yet. I'm currently working on a new > release of NetAddr::IP. Net::Radius will come next.

I produced a patch against 1.49 (even if both modules still have $VERSION set to '1.45'), which does the following: * [Dictionary.pm] accept a new keyword in dictionary file, namely "PACKET", that allows to define packet types * [Dictionary.pm] these packet types default to the current state-of-the-art according to http://www.iana.org/assignments/radius-types * [Dictionary.pm] the packet types can be accessed via ad-hoc methods * [Dictionary.pm] the constructor has been extended to accept a list of dictionary files to load upon creation (instead of a single one) * [Packet.pm] hardcoded mapping hashes in pack() and unpack() methods are now loaded from the dictionary This should have the benefit of an easy extendability in the future: one can add a dictionary file intended specifically for packet types, in case new RFCs add new packet types, without the need of a prompt patch on your side. In the package, you find: * diff files for the two modified modules (for you to easily check) * the patched modules * a new test for the added features Hope this helps, Flavio.

Download Net-Radius-proposed-patch.tar.gz
application/x-gzip 10.8k

Message body not shown because it is not plain text.

Mon Oct 23 16:40:37 2006 luismunoz [...] cpan.org - Correspondence added

From:

LUISMUNOZ [...] cpan.org

On Sat Oct 21 09:48:03 2006, POLETTIX wrote: Show quoted text

> > Yes, the module is still maintained. Unfortunately, I haven't had the > > time to put together a new release yet. I'm currently working on a new > > release of NetAddr::IP. Net::Radius will come next.

> > I produced a patch against 1.49 (even if both modules still have > $VERSION set to '1.45'), which does the following:

I'm just uploading v1.50, which includes your patch. Thanks a lot! -lem

Mon Jan 08 02:46:42 2007 luismunoz [...] cpan.org - Status changed from 'open' to 'resolved'