| Subject: | Duplicate code and deprecated |
| Date: | Mon, 5 Nov 2012 10:44:04 +0000 |
| To: | <bug-Catalyst-Plugin-Text-Xatena [...] rt.cpan.org> |
| From: | Tomas Doran <tomas.doran [...] timgroup.com> |
Hi
I notice your module entirely duplicates the functionality of
Catalyst::Plugin::Markdown, which is also a terribly bad idea.
As per: https://metacpan.org/module/Catalyst::Manual::ExtendingCatalyst
this should not be a plugin, as it doesn't affect application state at all.
I'd go so far as to say, given the markdown() function is side effect
free (and idempotent), that you're better off just importing the
function as needed, rather than having it as a method call.