Skip Menu |

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 80626
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: GAAS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.49
Fixed in: (no value)



Subject: Please avoid C++ style comments
 Net-SSLeay-1.49 fails to compile on some of our "classic" unixes like AIX and HPUX because it uses C++ style comments in the SSL_read() function.  The attached patch fixes that.

We used to 1.42 before and that version didn't have this problem.

Subject: Net-SSLeay-comment.patch
From 3cb5eeb314b83caf5c67374634eda28cd2492a34 Mon Sep 17 00:00:00 2001 From: Gisle Aas <gisle@activestate.com> Date: Sun, 4 Nov 2012 13:01:49 -0800 Subject: [PATCH] Avoid C++ style comments This was causing failures on AIX and HP-UX. --- SSLeay.xs | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/SSLeay.xs b/SSLeay.xs index 4564302..bd41a48 100644 --- a/SSLeay.xs +++ b/SSLeay.xs @@ -1240,15 +1240,16 @@ SSL_read(s,max=32768) New(0, buf, max, char); got = SSL_read(s, buf, max); - // If in list context, return 2-item list: - // first return value: data gotten, or undef on error (got<0) - // second return value: result from SSL_read() + /* If in list context, return 2-item list: + * first return value: data gotten, or undef on error (got<0) + * second return value: result from SSL_read() + */ if (GIMME_V==G_ARRAY) { EXTEND(SP, 2); PUSHs(sv_2mortal(got>=0 ? newSVpvn(buf, got) : newSV(0))); PUSHs(sv_2mortal(newSViv(got))); - // If in scalar or void context, return data gotten, or undef on error. + /* If in scalar or void context, return data gotten, or undef on error. */ } else { EXTEND(SP, 1); PUSHs(sv_2mortal(got>=0 ? newSVpvn(buf, got) : newSV(0))); -- 1.7.0.5
Subject: Re: [rt.cpan.org #80626] Please avoid C++ style comments
Date: Mon, 05 Nov 2012 07:28:54 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] open.com.au>
Thanks Gisle, Fixed in svn 357. Cheers. On Sunday, November 04, 2012 04:19:41 PM Gisle_Aas via RT wrote: Show quoted text
> Sun Nov 04 16:19:40 2012: Request 80626 was acted upon. > Transaction: Ticket created by GAAS > Queue: Net-SSLeay > Subject: Please avoid C++ style comments > Broken in: 1.49 > Severity: (no value) > Owner: Nobody > Requestors: GAAS@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=80626 > > > > Net-SSLeay-1.49 fails to compile on some of our "classic" unixes like AIX > and HPUX because it uses C++ style comments in the SSL_read() function. The > attached patch fixes that. > > We used to 1.42 before and that version didn't have this problem.
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.