Skip Menu |

This queue is for tickets about the Git-Repository CPAN distribution.

Report information
The Basics
Id: 80593
Status: resolved
Priority: 0/
Queue: Git-Repository

People
Owner: Nobody in particular
Requestors: jcrotty_alpine [...] hotmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.27
Fixed in: 1.28



Subject: git 1.8.0 tests break
==> Found dependencies: Git::Repository Searching Git::Repository on cpanmetadb ... --> Working on Git::Repository Fetching http://www.cpan.org/authors/id/B/BO/BOOK/Git-Repository-1.27.tar.gz -> OK Unpacking Git-Repository-1.27.tar.gz Entering Git-Repository-1.27 Checking configure dependencies from META.yml Checking if you have Module::Build 0.38 ... Yes (0.4003) Configuring Git-Repository-1.27 Running Build.PL Created MYMETA.yml and MYMETA.json Creating new 'Build' script for 'Git-Repository' version '1.27' -> OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0 ... Yes (0.98) Checking if you have List::Util 0 ... Yes (1.23) Checking if you have System::Command 1.05 ... Yes (1.07) Checking if you have File::Spec 0 ... Yes (3.33) Checking if you have File::Path 0 ... Yes (2.08_01) Checking if you have IPC::Open3 0 ... Yes (1.09) Checking if you have Cwd 0 ... Yes (3.36) Building and testing Git-Repository-1.27 Building Git-Repository # Tested Git::Repository 1.27, Perl 5.014002, /usr/local/perlbrew/perls/perl- 5.14.2/bin/perl t/00-load.t ........ ok # Testing _is_git with /usr/local/bin/git from /usr/local/jcrotty/repos/git/poma_tusko_backend/perl- lib/.cpanm/work/1351893991.28751/Git-Repository-1.27 # Testing _is_git with ../../../../../../../../../bin/git from /usr/local/jcrotty/repos/git/poma_tusko_backend/perl- lib/.cpanm/work/1351893991.28751/Git-Repository-1.27 t/05-try_git.t ..... ok # git version 1.8.0 t/06-version.t ..... ok t/07-version.t ..... ok t/10-new_fail.t .... ok warning: You appear to have cloned an empty repository. at t/11-create.t line 117. warning: You appear to have cloned an empty repository. at t/11-create.t line 132. warning: You appear to have cloned an empty repository. at t/11-create.t line 150. t/11-create.t ...... ok t/12-create.t ...... ok t/13-sudo.t ........ ok t/20-simple.t ...... ok t/21-submodule.t ... ok t/22-backward.t .... ok t/23-quiet.t ....... ok t/25-plugins.t ..... ok t/30-log.t ......... ok # Failed test 'commit 1 body' # at t/40-plugin-log.t line 53. # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 # ' # expected: '' # Failed test 'commit 2 body' # at t/40-plugin-log.t line 53. # got: 'of data # # Change-Id: I32d05f060bf19e6c08091bc88afc37b784b4c349 # ' # expected: 'of data # ' # Failed test 'commit 2 body' # at t/40-plugin-log.t line 53. # got: 'of data # # Change-Id: I32d05f060bf19e6c08091bc88afc37b784b4c349 # ' # expected: 'of data # ' # Failed test 'commit 2 body' # at t/40-plugin-log.t line 53. # got: 'of data # # Change-Id: I32d05f060bf19e6c08091bc88afc37b784b4c349 # ' # expected: 'of data # ' # Failed test 'commit 1 body' # at t/40-plugin-log.t line 53. # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 # # ' # expected: '' # Failed test 'commit 2 body' # at t/40-plugin-log.t line 53. # got: 'of data # # Change-Id: I32d05f060bf19e6c08091bc88afc37b784b4c349 # ' # expected: 'of data # ' # Failed test 'commit 1 body' # at t/40-plugin-log.t line 53. # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 # ' # expected: '' # Failed test 'commit 2 body' # at t/40-plugin-log.t line 53. # got: 'of data # # Change-Id: I32d05f060bf19e6c08091bc88afc37b784b4c349 # ' # expected: 'of data # ' # Failed test 'commit 1 body' # at t/40-plugin-log.t line 53. # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 # ' # expected: '' # Failed test 'commit 2 body' # at t/40-plugin-log.t line 53. # got: 'of data # # Change-Id: I32d05f060bf19e6c08091bc88afc37b784b4c349 # ' # expected: 'of data # ' # Failed test 'commit 1 body' # at t/40-plugin-log.t line 53. # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 # ' # expected: '' # Looks like you failed 11 tests of 86. t/40-plugin-log.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 11/86 subtests t/pod-coverage.t ... skipped: Test::Pod::Coverage 1.08 required for testing POD coverage t/pod.t ............ skipped: Test::Pod 1.22 required for testing POD Test Summary Report ------------------- t/40-plugin-log.t (Wstat: 2816 Tests: 86 Failed: 11) Failed tests: 9, 17, 25, 37, 42, 50, 55, 63, 68, 76, 81 Non-zero exit status: 11 Files=17, Tests=535, 3 wallclock secs ( 0.09 usr 0.02 sys + 1.09 cusr 0.64 csys = 1.84 CPU) Result: FAIL Failed 1/17 test programs. 11/535 subtests failed. -> FAIL Installing Git::Repository failed. See /usr/local/tusko/fbl/perl- lib/.cpanm/build.log for details. -> FAIL Bailing out the installation for Dist-Zilla-Plugin-ChangeStats-Git-0.1.3. Retry with --prompt or --force. Already tried Git::Repository. Skipping. -> FAIL Bailing out the installation for Dist-Zilla-PluginBundle-YANICK-0.12.0. Retry with --prompt or --force.
Subject: Re: [rt.cpan.org #80593] git 1.8.0 tests break
Date: Sat, 3 Nov 2012 00:44:40 +0100
To: Joseph Crotty via RT <bug-Git-Repository [...] rt.cpan.org>
From: "Philippe Bruhat (BooK)" <book [...] cpan.org>
On Fri, Nov 02, 2012 at 06:09:34PM -0400, Joseph Crotty via RT wrote: Show quoted text
> > # Failed test 'commit 1 body' > # at t/40-plugin-log.t line 53. > # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 > # ' > # expected: ''
It seems the Change-Id line is added by external tools like Gerrit. Is that installed on your system? Any way I could detect this? -- Philippe Bruhat (BooK) When it is time for voting- / In the West or in the East- Why must we always settle for- / The man we hate the least? (Intro poem to Groo The Wanderer #108 (Epic))
Subject: Re: [rt.cpan.org #80593] git 1.8.0 tests break
Date: Sat, 3 Nov 2012 01:08:42 +0100
To: Joseph Crotty via RT <bug-Git-Repository [...] rt.cpan.org>
From: "Philippe Bruhat (BooK)" <book [...] cpan.org>
On Sat, Nov 03, 2012 at 12:44:40AM +0100, Philippe Bruhat (BooK) wrote: Show quoted text
> On Fri, Nov 02, 2012 at 06:09:34PM -0400, Joseph Crotty via RT wrote:
> > > > # Failed test 'commit 1 body' > > # at t/40-plugin-log.t line 53. > > # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 > > # ' > > # expected: ''
> > It seems the Change-Id line is added by external tools like Gerrit. > > Is that installed on your system? Any way I could detect this? >
After some more research, and some help from the #git irc channel, it seems that this could be a gerrit-related hook that is in the templates directory for new repositories. If you could confirm that you have such templates installed, that would help me adapt my tests for this case, and avoid future failures. If you're worried about Git::Repository itself, there's no issue, it should work just fine. -- Philippe Bruhat (BooK) If you doubt a friend, you are not being a friend. (Moral from Groo The Wanderer #62 (Epic))
From: jcrotty_alpine [...] hotmail.com
On Fri Nov 02 20:08:51 2012, BOOK wrote: Show quoted text
> On Sat, Nov 03, 2012 at 12:44:40AM +0100, Philippe Bruhat (BooK) wrote:
> > On Fri, Nov 02, 2012 at 06:09:34PM -0400, Joseph Crotty via RT wrote:
> > > > > > # Failed test 'commit 1 body' > > > # at t/40-plugin-log.t line 53. > > > # got: 'Change-Id: I87d6318b88327f8f573b9784777d9018ca0eb660 > > > # ' > > > # expected: ''
> > > > It seems the Change-Id line is added by external tools like Gerrit. > > > > Is that installed on your system? Any way I could detect this? > >
> > After some more research, and some help from the #git irc channel, it > seems that this could be a gerrit-related hook that is in the templates > directory for new repositories. > > If you could confirm that you have such templates installed, that would > help me adapt my tests for this case, and avoid future failures. > > If you're worried about Git::Repository itself, there's no issue, > it should work just fine. >
Yes, I am using Gerrit. The hook is always located here: .git/hooks/commit-msg I have my unix user setup with a ~/.git_template/hooks/commit-msg file and my .gitconfig with the following: snip [init] templatedir = ~/.git_template snip That way whenever a new repo is created the gerrit commit-msg hook is always copied to .git/hooks/ from my templatedir. We use Gerrit for all our work repos and this reduces setup time per repo.
Subject: Re: [rt.cpan.org #80593] git 1.8.0 tests break
Date: Sat, 3 Nov 2012 09:07:30 +0100
To: Joseph Crotty via RT <bug-Git-Repository [...] rt.cpan.org>
From: "Philippe Bruhat (BooK)" <book [...] cpan.org>
On Fri, Nov 02, 2012 at 11:20:50PM -0400, Joseph Crotty via RT wrote: Show quoted text
> > > > If you could confirm that you have such templates installed, that would > > help me adapt my tests for this case, and avoid future failures. > >
> > Yes, I am using Gerrit. The hook is always located here: > > .git/hooks/commit-msg > > I have my unix user setup with a ~/.git_template/hooks/commit-msg file and my > .gitconfig with the following: > > snip > [init] > templatedir = ~/.git_template > snip > > That way whenever a new repo is created the gerrit commit-msg hook is always copied > to .git/hooks/ from my templatedir. We use Gerrit for all our work repos and this > reduces setup time per repo. >
OK, so this is a case that my tests weren't prepared for. I'll adapt the tests so that they remove the commit-msg hook from the test repositories. Thanks for the bug report and the explanation! Show quoted text
> > If you're worried about Git::Repository itself, there's no issue, > > it should work just fine.
And I confirm that the issue was with the test (that were not taking hooks added by templates into account) and not with the module itself. -- Philippe Bruhat (BooK) Your life is the greatest show of all. Do not let anyone else direct. (Moral from Groo The Wanderer #84 (Epic))