Skip Menu |

This queue is for tickets about the App-CPAN2Pkg CPAN distribution.

Report information
The Basics
Id: 80420
Status: resolved
Priority: 0/
Queue: App-CPAN2Pkg

People
Owner: Nobody in particular
Requestors: SHLOMIF [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 3.001
Fixed in: (no value)



Subject: CPAN2Pkg happily uploads packages with "no description found" + Need to manually review the .spec before uploading
CPAN2Pkg happily uploades packages with no descriptions or summaries found, while it should generate an error in that case. Furthermore, it should have an option for the packager to review the .spec before uploading it and confirm that the .spec is OK. For more information, see this conversation on #mageia-dev: Thanks in advance, -- Shlomi Fish <rindolf> Yay! I'm the number one submitter for the time frame - http://pkgsubmit.mageia.org/ . Surpassing fwang. <[mbot> [ Build system status ] <malo> neoclust: yes :-) <neoclust> rindolf: yes but doing good packages would be better than doing a lot <neoclust> malo: not really nice _ in names <neoclust> malo: can't we change it to use - instead ? <malo> neoclust: true, but policy is not to introduce _ in names, but when they are from upstream it's acceptable ... <rindolf> /~ How do we measure quality? In foot-pounds, in foot-pounds ~/ - http://www.shlomifish.org/Files/files/music/mp3-ogg/Singing%20Science%20Songs%20-%20How%20Do%20We%20Measure%20Energy.mp3 <neoclust> malo: ah ok <-- remmy_ has quit (Ping timeout: 244 seconds) <malo> neoclust: I'd prefer not changing <neoclust> rindolf: i am not kidding <neoclust> rindolf: doing packages with descriptions is not really acceptable <malo> neoclust: we should have a rpmlint activated for that <neoclust> malo: in fact it has one description :) <neoclust> %description: <neoclust> no description found <neoclust> \o/ <malo> rindolf: maybe the cpan2pkg should be patched to raise an error if there is no description <malo> rindolf: or maybe later in the tool chain you use <neoclust> malo: no maybe packager should be more pointless on what they do <rindolf> neoclust: more pointless? <rindolf> neoclust: pointlessness is not a virtue. <malo> neoclust: like importing package that already exist?? :-P <malo> rindolf: neoclust means alert I guess <neoclust> rindolf: i mean <neoclust> rindolf: i mean <neoclust> rindolf: i mean finical <rindolf> neoclust: finical? <neoclust> malo: yes that suck :) <rindolf> What is finical? <malo> rindolf: neoclust is making up words now :-) <neoclust> rindolf: be more serious in somple words <rindolf> neoclust: OK. --> maat|lin (~maat@unaffiliated/maat) has joined #mageia-dev <neoclust> rindolf: be more serious in simple words <malo> neoclust: btw your ocaml-js had completely wrong rpm groups as well <rindolf> neoclust: well, I was using CPAN2Pkg - it didn't ask me before uploading the packages with the "no description" descs. Maybe it should. <neoclust> malo: i imported the one from mandriva my biggest error :) <neoclust> malo: i will add obsoletes in the one with _ <neoclust> rindolf: you NEED to read your spec file before uploading <neoclust> you MUST read it <rindolf> neoclust: blame jq. <malo> neoclust: fmonnier was ocaml maintainer in Mandriva and is now working with me on the ocaml packages in Mageia <malo> neoclust: I don't know who manages the ocaml stack in Mandriva now ... <neoclust> rindolf: jq ? <neoclust> rindolf: why ? <rindolf> neoclust: he is the CPAN2Pkg maintainer. <neoclust> rindolf: YOU upload it badly and this should someone else fault ? <rindolf> neoclust: cpan2pkg uploaded it for me. <rindolf> neoclust: it doesn't let me review the .spec. <neoclust> rindolf: so don't use this tool that's all or patch it to add a --noupload option <rindolf> neoclust: OK. <rindolf> neoclust: maybe we should just fix this tool. <neoclust> rindolf: or use a user makerpm that doesn't have commit right on our svn so it won't upload and push <neoclust> rindolf: "or patch it to add a --noupload option <neoclust> rindolf: "or patch it to add a --noupload option" <neoclust> rindolf: this is what i told no ? <rindolf> neoclust: or let us review the .spec before it uploads. <rindolf> neoclust: OK, I'll file a bug report.
On Fri Oct 26 11:48:58 2012, SHLOMIF wrote: Show quoted text
> CPAN2Pkg happily uploades packages with no descriptions or summaries > found, while it should generate an error in that case. Furthermore, it > should have an option for the packager to review the .spec before > uploading it and confirm that the .spec is OK.
nope, cpan2pkg is behaving correctly: if cpan2dist run was error-free, it shouldn't generate an error. cpan2pkg is the glue between different tools / infrastructure, not a checker. i do agree that cpanplus::dist::mageia (the engine used by cpan2dist which is called by cpan2pkg) should behave differently, though. in particular, i think that just returning "" instead of "no description found" would do the trick, since in that case the upload would fail (catch by rpmlint). note that cpanplus::dist::mageia needs an overhaul, long overdue.
cpanplus-dist-mageia 2.000 released