Skip Menu |

This queue is for tickets about the Git-Repository CPAN distribution.

Report information
The Basics
Id: 80321
Status: resolved
Priority: 0/
Queue: Git-Repository

People
Owner: Nobody in particular
Requestors: iarnell [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.26
Fixed in: 1.28



t/23-quiet.t fails if you don't have email/name configured yet: *** Please tell me who you are. Run git config --global user.email "you@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for <mockbuild@microstar.(none)>) not allowed at t/23-quiet.t line 40. # Looks like you planned 7 tests but ran 1. # Looks like your test exited with 128 just after 1. t/23-quiet.t ....... Dubious, test returned 128 (wstat 32768, 0x8000) Failed 6/7 subtests Can easily be avoided by explicitly setting the appropriate $ENV vars, as done in t/20-simple.t diff -up Git-Repository-1.27/t/23-quiet.t.orig Git-Repository-1.27/t/23-quiet.t --- Git-Repository-1.27/t/23-quiet.t.orig 2012-10-11 02:00:28.000000000 -0600 +++ Git-Repository-1.27/t/23-quiet.t 2012-10-21 15:34:05.000000000 -0600 @@ -8,6 +8,10 @@ has_git('1.5.0'); # clean up the environment delete @ENV{qw( GIT_DIR GIT_WORK_TREE )}; +$ENV{GIT_AUTHOR_NAME} = 'Test Author'; +$ENV{GIT_AUTHOR_EMAIL} = 'test.author@example.com'; +$ENV{GIT_COMMITTER_NAME} = 'Test Committer'; +$ENV{GIT_COMMITTER_EMAIL} = 'test.committer@example.com'; # a place to put a git repository my $r = test_repository;
Subject: Re: [rt.cpan.org #80321]
Date: Sat, 3 Nov 2012 16:18:54 +0100
To: Iain Arnell via RT <bug-Git-Repository [...] rt.cpan.org>
From: "Philippe Bruhat (BooK)" <book [...] cpan.org>
On Sun, Oct 21, 2012 at 05:38:23PM -0400, Iain Arnell via RT wrote: Show quoted text
> > diff -up Git-Repository-1.27/t/23-quiet.t.orig > Git-Repository-1.27/t/23-quiet.t > --- Git-Repository-1.27/t/23-quiet.t.orig 2012-10-11 > 02:00:28.000000000 -0600 > +++ Git-Repository-1.27/t/23-quiet.t 2012-10-21 15:34:05.000000000 -0600 > @@ -8,6 +8,10 @@ has_git('1.5.0'); > > # clean up the environment > delete @ENV{qw( GIT_DIR GIT_WORK_TREE )}; > +$ENV{GIT_AUTHOR_NAME} = 'Test Author'; > +$ENV{GIT_AUTHOR_EMAIL} = 'test.author@example.com'; > +$ENV{GIT_COMMITTER_NAME} = 'Test Committer'; > +$ENV{GIT_COMMITTER_EMAIL} = 'test.committer@example.com'; > > # a place to put a git repository > my $r = test_repository; >
Thanks, applied! -- Philippe Bruhat (BooK) He who revels in being bigger forgets that he is the larger target. (Moral from Groo #5 (Image))