Skip Menu |

This queue is for tickets about the Role-Tiny CPAN distribution.

Report information
The Basics
Id: 80290
Status: resolved
Priority: 0/
Queue: Role-Tiny

People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)



Subject: t/does-Moo.t assumes too much and fails
Role::Tiny in its current form makes Moo non-upgradeable. A Moo upgrade will pull in R::T which will run its tests against the old Moo, which wikl fail. rabbit@Ahasver:~$ cpanm Moo Role::Tiny Moo is up to date. (1.000004) Role::Tiny is up to date. (1.002000) rabbit@Ahasver:~$ cpanm http://cpan.metacpan.org/authors/id/M/MS/MSTROUT/Moo-0.091007.tar.gz --> Working on http://cpan.metacpan.org/authors/id/M/MS/MSTROUT/Moo-0.091007.tar.gz Fetching http://cpan.metacpan.org/authors/id/M/MS/MSTROUT/Moo-0.091007.tar.gz ... OK Configuring Moo-0.091007 ... OK Building and testing Moo-0.091007 ... OK Successfully installed Moo-0.091007 1 distribution installed rabbit@Ahasver:~$ cpanm --reinstall Role::Tiny -v cpanm (App::cpanminus) 1.5007 on perl 5.014002 built for x86_64-linux-thread-multi-ld Work directory is /home/rabbit/.cpanm/work/1350675318.3630 You have make /usr/bin/make You have LWP 6.04 You have /bin/tar: tar (GNU tar) 1.23 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by John Gilmore and Jay Fenlason. You have /usr/bin/unzip Searching Role::Tiny on cpanmetadb ... --> Working on Role::Tiny Fetching http://search.cpan.org/CPAN/authors/id/M/MS/MSTROUT/Role-Tiny-1.002000.tar.gz ... OK Unpacking Role-Tiny-1.002000.tar.gz Role-Tiny-1.002000/ Role-Tiny-1.002000/maint/ Role-Tiny-1.002000/maint/bump-version Role-Tiny-1.002000/maint/Makefile.PL.include Role-Tiny-1.002000/lib/ Role-Tiny-1.002000/lib/Role/ Role-Tiny-1.002000/lib/Role/Tiny.pm Role-Tiny-1.002000/lib/Role/Tiny/ Role-Tiny-1.002000/lib/Role/Tiny/With.pm Role-Tiny-1.002000/README Role-Tiny-1.002000/t/ Role-Tiny-1.002000/t/does.t Role-Tiny-1.002000/t/does-Moo.t Role-Tiny-1.002000/t/role-basic-00-load.t Role-Tiny-1.002000/t/lib/ Role-Tiny-1.002000/t/lib/Bar.pm Role-Tiny-1.002000/t/lib/Baz.pm Role-Tiny-1.002000/t/role-basic-exceptions.t Role-Tiny-1.002000/t/role-basic-basic.t Role-Tiny-1.002000/t/role-tiny.t Role-Tiny-1.002000/t/around-does.t Role-Tiny-1.002000/t/role-with-inheritance.t Role-Tiny-1.002000/t/role-tiny-with.t Role-Tiny-1.002000/t/role-duplication.t Role-Tiny-1.002000/t/role-tiny-composition.t Role-Tiny-1.002000/t/role-basic/ Role-Tiny-1.002000/t/role-basic/lib/ Role-Tiny-1.002000/t/role-basic/lib/My/ Role-Tiny-1.002000/t/role-basic/lib/My/Example.pm Role-Tiny-1.002000/t/role-basic/lib/My/Does/ Role-Tiny-1.002000/t/role-basic/lib/My/Does/Basic.pm Role-Tiny-1.002000/t/role-basic/lib/MyTests.pm Role-Tiny-1.002000/t/role-basic/lib/Try/ Role-Tiny-1.002000/t/role-basic/lib/Try/Tiny.pm Role-Tiny-1.002000/t/role-basic/lib/TestMethods.pm Role-Tiny-1.002000/t/modifiers.t Role-Tiny-1.002000/t/namespace-clean.t Role-Tiny-1.002000/t/role-basic-bugs.t Role-Tiny-1.002000/t/role-basic-composition.t Role-Tiny-1.002000/META.yml Role-Tiny-1.002000/META.json Role-Tiny-1.002000/MANIFEST Role-Tiny-1.002000/Makefile.PL Role-Tiny-1.002000/Changes Entering Role-Tiny-1.002000 Checking configure dependencies from META.yml Checking if you have ExtUtils::MakeMaker 0 ... Yes (6.62) Configuring Role-Tiny-1.002000 ... Running Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Role::Tiny Writing MYMETA.yml and MYMETA.json OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0.96 ... Yes (0.98) Checking if you have Test::Fatal 0.003 ... Yes (0.009) Building and testing Role-Tiny-1.002000 ... cp lib/Role/Tiny/With.pm blib/lib/Role/Tiny/With.pm cp lib/Role/Tiny.pm blib/lib/Role/Tiny.pm Manifying blib/man3/Role::Tiny::With.3 Manifying blib/man3/Role::Tiny.3 PERL_DL_NONLAZY=1 /home/rabbit/perl5/perlbrew/perls/5.14.2/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/around-does.t ............. ok t/does-Moo.t ................ 1/14 # Failed test 'Local::Class1->does(Local::Role2)' # at t/does-Moo.t line 50. # Failed test 'Local::Class1->DOES(Local::Role2)' # at t/does-Moo.t line 51. # Looks like you failed 2 tests of 14. t/does-Moo.t ................ Dubious, test returned 2 (wstat 512, 0x200) Failed 2/14 subtests t/does.t .................... ok t/modifiers.t ............... ok t/namespace-clean.t ......... ok t/role-basic-00-load.t ...... 1/1 # Testing Role::Tiny 1.002, Perl 5.014002, /home/rabbit/perl5/perlbrew/perls/5.14.2/bin/perl t/role-basic-00-load.t ...... ok t/role-basic-basic.t ........ ok t/role-basic-bugs.t ......... ok t/role-basic-composition.t .. ok t/role-basic-exceptions.t ... ok t/role-duplication.t ........ ok t/role-tiny-composition.t ... ok t/role-tiny-with.t .......... ok t/role-tiny.t ............... ok t/role-with-inheritance.t ... ok Test Summary Report ------------------- t/does-Moo.t (Wstat: 512 Tests: 14 Failed: 2) Failed tests: 3-4 Non-zero exit status: 2 Files=15, Tests=111, 1 wallclock secs ( 0.08 usr 0.02 sys + 0.42 cusr 0.09 csys = 0.61 CPU) Result: FAIL Failed 1/15 test programs. 2/111 subtests failed. make: *** [test_dynamic] Error 255 FAIL ! Installing Role::Tiny failed. See /home/rabbit/.cpanm/build.log for details.
D'oh! Make t/does-Moo.t an author test, rather than a public test?
Hmmm... it may depend on what version you're upgrading from. Going from Moo 1.000003 to 1.000005 didn't seem a problem.
Patch in repo... http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=gitmo/Role- Tiny.git;a=commitdiff;h=77fce1af0a912236487c8be47fe532c996db3055
Fixed in 1.002001, just uploaded to CPAN