Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Conflicts CPAN distribution.

Report information
The Basics
Id: 80271
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-Conflicts
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: 0.09

History Show all quoted text
  Thu Oct 18 18:22:34 2012 ether [...] cpan.org - Ticket created
Subject: Plugin silently doesn't add conflicts checking if [Conflicts] declaration appears too soon in dist.ini
If [Conflicts] appears in dist.ini above [MakeMaker] or [ModuleBuild] (or [@Basic], which includes [MakeMaker]), then there is no Makefile.PL generated yet, so setup_installer() can't find any file to insert its conflict checking code into - which means that the installation silently gets no conflicts checking. I'll be sending a patch which calls log_fatal if no *.PL file is patched - I can't think of a good reason why the user would deliberately want to circumvent this behaviour.
  Thu Oct 18 18:40:56 2012 ether [...] cpan.org - Correspondence added
On Thu Oct 18 15:22:34 2012, ETHER wrote: Show quoted text
> I'll be sending a patch which calls log_fatal if no *.PL file is patched > - I can't think of a good reason why the user would deliberately want to > circumvent this behaviour.
Patched, in https://github.com/karenetheridge/Dist-Zilla-Plugin-CheckConflicts/tree/topic/check_if_no_makefile
  Thu Oct 18 18:40:57 2012 ether [...] cpan.org - Status changed from 'new' to 'patched'
  Thu Mar 28 19:49:55 2013 ether [...] cpan.org - Correspondence added
On Thu Oct 18 15:40:56 2012, ETHER wrote: Show quoted text
> On Thu Oct 18 15:22:34 2012, ETHER wrote:
> > I'll be sending a patch which calls log_fatal if no *.PL file is
> patched
> > - I can't think of a good reason why the user would deliberately
> want to
> > circumvent this behaviour.
> > Patched, in > https://github.com/karenetheridge/Dist-Zilla-Plugin- > CheckConflicts/tree/topic/check_if_no_makefile
I don't know why I created this repository with the wrong name - please see https://github.com/karenetheridge/Dist-Zilla-Plugin-Conflicts/tree/topic/check_if_no_makefile
  Thu Mar 28 19:49:58 2013 The RT System itself - Status changed from 'patched' to 'open'
  Mon Apr 01 15:42:14 2013 DROLSKY [...] cpan.org - Fixed in 0.09 added
  Mon Apr 01 15:45:09 2013 DROLSKY [...] cpan.org - Status changed from 'open' to 'resolved'