Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Farly CPAN distribution.

Report information
The Basics
Id: 80265
Status: resolved
Priority: 0/
Queue: Farly
People
Owner: Nobody in particular
Requestors: LUKAST [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Oct 18 10:26:38 2012 LUKAST [...] cpan.org - Ticket created
Subject: Added support for routing in Cisco parser and template
Hello, I have created a patch to Farly which adds support for routing config to the Cisco Parser and the corresponding template. Since I am using a Cisco FWSM (running a current ios) instead of ASA, my patch uses FWSM syntax. I am using Farly to work on my FWSM config, and I did not experience any syntax differences in the past. I hope the syntax is the same for routing, too. My patch updates 't/test.cfg' and adds two routing entries. All tests pass. The only change in the tests was to add the routing config, and to increase the number of ce's by two. I also pushed VERSION to 0.09 in all .pm files. Seeing this new feature in a new Farly release would make life much more easy for me. Feel free to contact me via mail or irc if you have any questions. I have created a #farly channel on irc.perl.org, but I am currently the only person in there :) By the way, I am working with Farly a lot these days. It is possible that I have more code to contribute in the future. A github repository might be useful. I also have some Ideas to improve Object::KVC::* cheers, Lukas
Subject: routing.patch

Message body is not shown because it is too large.

  Thu Oct 18 21:59:57 2012 trystanzj [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #80265] Added support for routing in Cisco parser and template
Date: Thu, 18 Oct 2012 19:59:45 -0600
To: bug-Farly [...] rt.cpan.org
From: Trystan <trystanzj [...] gmail.com>
Thanks! You just made my month. This is the first patch/request I've received for Farly. I'm working on a couple of minor bug fixes for 0.09, I absolutely will include your patch in 0.09. Trystan On Thu, Oct 18, 2012 at 8:26 AM, Lukas Thiemeier via RT < bug-Farly@rt.cpan.org> wrote: Show quoted text
> Thu Oct 18 10:26:38 2012: Request 80265 was acted upon. > Transaction: Ticket created by LUKAST > Queue: Farly > Subject: Added support for routing in Cisco parser and template > Broken in: (no value) > Severity: Wishlist > Owner: Nobody > Requestors: LUKAST@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=80265 > > > > Hello, > > I have created a patch to Farly which adds support for routing config to > the Cisco Parser and the corresponding template. > > Since I am using a Cisco FWSM (running a current ios) instead of ASA, my > patch uses FWSM syntax. > > I am using Farly to work on my FWSM config, and I did not experience any > syntax differences in the past. I hope the syntax is the same for > routing, too. > > My patch updates 't/test.cfg' and adds two routing entries. All tests > pass. The only change in the tests was to add the routing config, and to > increase the number of ce's by two. > > I also pushed VERSION to 0.09 in all .pm files. > > Seeing this new feature in a new Farly release would make life much more > easy for me. Feel free to contact me via mail or irc if you have any > questions. I have created a #farly channel on irc.perl.org, but I am > currently the only person in there :) > > By the way, I am working with Farly a lot these days. It is possible > that I have more code to contribute in the future. A github repository > might be useful. I also have some Ideas to improve Object::KVC::* > > cheers, Lukas >
  Thu Oct 18 21:59:58 2012 The RT System itself - Status changed from 'new' to 'open'
  Sat Oct 20 16:06:26 2012 trystanzj [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #80265] Added support for routing in Cisco parser and template
Date: Sat, 20 Oct 2012 14:06:14 -0600
To: "bug-Farly [...] rt.cpan.org" <bug-Farly [...] rt.cpan.org>
From: Trystan <trystanzj [...] gmail.com>
Lukas, I integrated your patch. I needed to change your grammar for Farly::ASA::Parser in order to support the Cisco ASA "track" and "tunneled" route options. I also changed the DEFAULTROUTE token to match /0(\s+)0/ as well as a single '0'. I haven't seen configs with a single 0, was that correct? In ::Annotator, I also added a DEFAULTROUTE visit method to rewrite the DEFAULTROUTE Token to an ::IPv4::Network "0.0.0.0 0.0.0.0" object. Does your FWSM support "route outside 0.0.0.0 0.0.0.0 ...?" Can you use "0.0.0.0 0.0.0.0" in the config even if shows "0 0" in the running-config? I also tweaked the template test to use a reference object instead of integer wrapper object. I setup a github repo for Farly at https://github.com/trystanzj/Farly and pushed version 0.09 to this repo. Would you able to test my changes in v0.09 and let me know if they work for you? Thanks for your help, I really appreciate it. Trystan
  Mon Oct 22 05:29:09 2012 LUKAST [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #80265] Added support for routing in Cisco parser and template
Date: Mon, 22 Oct 2012 11:28:42 +0200
To: bug-Farly [...] rt.cpan.org
From: Lukas Thiemeier <pause [...] thiemeier.net>
On 10/20/2012 10:06 PM, Trystan via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=80265 > > > Lukas, > I integrated your patch. I needed to change your grammar for > Farly::ASA::Parser in order to support the Cisco ASA "track" and "tunneled" > route options. I also changed the DEFAULTROUTE token to match /0(\s+)0/ as > well as a single '0'. I haven't seen configs with a single 0, was that > correct? > > In ::Annotator, I also added a DEFAULTROUTE visit method to rewrite the > DEFAULTROUTE Token to an ::IPv4::Network "0.0.0.0 0.0.0.0" object. Does > your FWSM support "route outside 0.0.0.0 0.0.0.0 ...?" Can you use "0.0.0.0 > 0.0.0.0" in the config even if shows "0 0" in the running-config? > > I also tweaked the template test to use a reference object instead of > integer wrapper object. > > I setup a github repo for Farly at https://github.com/trystanzj/Farly and > pushed version 0.09 to this repo. > > Would you able to test my changes in v0.09 and let me know if they work for > you? > > Thanks for your help, I really appreciate it. > > Trystan >
Hi Trystan, The single "0" was my mistake. I didn't pay attantion enough. sorry. I removed it from the parser and sent you a pull-request on github. Using "0.0.0.0" instead of "0" in my FWSM works fine. I guess "0" is just a shortcut for "0.0.0.0". I tested v0.09 without any problems. I had no time for deep inspection, but all my FarlyX-compatiblity-tests pass, and my scripts still work as expected. I think it is safe to release 0.09. Lukas I think it is safe to
  Thu Nov 29 23:03:20 2012 TJOHNSON [...] cpan.org - Correspondence added
Route model added in Farly 0.09... closing this request.
  Thu Nov 29 23:03:21 2012 TJOHNSON [...] cpan.org - Status changed from 'open' to 'resolved'