Bug #80171 for System-Command: eval is hiding IPC::Open3 exceptions

Sat Oct 13 19:48:23 2012 mods [...] hank.org - Ticket created

What's the point of the eval here? It's hiding all open3 exceptions. Might be nice to see the error that the program doesn't exist, for example: # start the command $pid = eval { open3( $in, $out, $err, @cmd ); }; return ( $pid, $in, $out, $err ); It's hiding it because it's called within another eval: my ( $pid, $in, $out, $err ) = eval { $_spawn->(@cmd); };

Thu Oct 18 03:58:37 2012 book [...] cpan.org - Correspondence added

On Sat Oct 13 19:48:23 2012, HANK wrote: Show quoted text

> What's the point of the eval here? It's hiding all open3 exceptions. > Might be nice to see the > error that the program doesn't exist, for example: > > # start the command > $pid = eval { open3( $in, $out, $err, @cmd ); }; > > return ( $pid, $in, $out, $err ); > > It's hiding it because it's called within another eval: > > my ( $pid, $in, $out, $err ) = eval { $_spawn->(@cmd); };

That eval comes from a refactoring step, and got duplicated in the move. Thanks for spotting and reporting it. -- BooK

Thu Oct 18 03:58:38 2012 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 20 10:59:03 2012 dolmen [...] cpan.org - Requestor DOLMEN added

Tue Nov 20 10:59:55 2012 dolmen [...] cpan.org - Subject changed from (no value) to 'evel is hiding IPC::Open3 exceptions'

Tue Nov 20 10:59:55 2012 dolmen [...] cpan.org - Severity Normal changed to Important

Tue Nov 20 11:00:50 2012 dolmen [...] cpan.org - Correspondence added

Subject:

eval is hiding IPC::Open3 exceptions

Le 2012-10-18 09:58:37, BOOK a écrit : Show quoted text

> That eval comes from a refactoring step, and got duplicated in the move. > Thanks for spotting and reporting it. > > -- BooK

Committed in https://github.com/book/System-Command/commit/f19b83b5228bc6746879e0b52a7acbfe4fc82672 But unfortunately not yet released... -- Olivier Mengué - http://perlresume.org/DOLMEN

Tue Nov 20 11:01:03 2012 dolmen [...] cpan.org - Subject changed from 'evel is hiding IPC::Open3 exceptions' to 'eval is hiding IPC::Open3 exceptions'

Mon Nov 26 09:48:19 2012 book [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Nov 26 09:48:20 2012 book [...] cpan.org - Fixed in 1.08 added