Subject: | Error if req params not a hashref |
Hi,
CatalystX-ExtJS-Direct and others change $c->req so that params might not
be a hashref. In most cases, it's just undef.
I've added a bit of extra protection in the attached patch.
( If in doubt, treat it as "couldn't hurt" )
It'd be great if you could apply and release, please?
Gareth
Subject: | CatalystX-DebugFilter-0.09.patch |
diff -Naur /home/staff/gbjk/.cpanm/work/1350041192.16558/CatalystX-DebugFilter-0.09/lib/CatalystX/DebugFilter.pm CatalystX-DebugFilter-0.09/lib/CatalystX/DebugFilter.pm
--- /home/staff/gbjk/.cpanm/work/1350041192.16558/CatalystX-DebugFilter-0.09/lib/CatalystX/DebugFilter.pm 2011-02-24 17:43:34.000000000 +0000
+++ CatalystX-DebugFilter-0.09/lib/CatalystX/DebugFilter.pm 2012-10-10 15:29:05.988884550 +0100
@@ -88,7 +88,7 @@
foreach my $type (@types) {
my $method = join '_', grep { $_ } $type, 'parameters';
my $params = $req->$method;
- next if !%$params;
+ next unless defined $params && ref $params && %$params;
my $copy = { %$params };
$is_filtered += _filter_hash_ref( $copy, @filters );
if($is_filtered){