Subject: | The docs ... are a bit typo'ed |
Date: | Fri, 12 Oct 2012 03:31:24 +0100 |
To: | bugs-Data-ObjectGenerator [...] rt.cpan.org |
From: | Matt S Trout <mst [...] shadowcat.co.uk> |
my $Tmp = Data::ObjectGenerator->Template;
perl variables are lower case as are method names so this should be
my $tmp = Data::ObjectGenerator->template;
--
my $generator = new Data::ObjectGenerator->new(template => $template);
I think the extra 'new' is wrong - maybe:
my $generator = Data::ObjectGenerator->new(template => $template);
is right?
--
Bugtracker is:
http://rt.cpan.org/NoAuth/Bugs.html?Dist=NIFTY-Nirvana-SampleGen
I feel this is a copy and paste error.
--
our $VERSION = '0.0.2';
this is wrong - a three part version like that is
our $VERSION = '0.000002'; # three digits per part
or you'll screw up packaging people in FreeBSD/Debian/etc.
--
I've no idea about the code. I didn't get that far ...
--
Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue
http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/
Email me now on mst (at) shadowcat.co.uk and let's chat about how our Catalyst
commercial support, training and consultancy packages could help your team.