Bug #80078 for DBD-CSV: bug in DBD::CSV causes select to fail

Tue Oct 09 13:30:41 2012 BENBOOTH [...] cpan.org - Ticket created

Subject:

bug in DBD::CSV causes select to fail

I was trying to use DBD::CSV 0.36 and got this error message: DBD::CSV::st execute failed: Execution ERROR: Can't call method "getline" on an undefined value at /Library/Perl/5.12/DBD/CSV.pm line 433. . at /System/Library/Perl/Extras/5.12/darwin-thread-multi-2level/DBI/DBD/SqlEngine.pm line 795 [for Statement "select * from stdin"] at /Users/bbooth/bin/dbdcsv line 98. at /Users/bbooth/bin/dbdcsv line 98 I tracked down the problem to a bug in lines 424 and 434 of DBD/CSV.pm: $tbl->{csv_csv_in}- Show quoted text

>getline should be changed to $attrs->{csv_csv_in}->getline. After applying this change,

DBD::CSV now works for me.

Wed Oct 10 02:12:29 2012 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #80078] bug in DBD::CSV causes select to fail
Date:	Wed, 10 Oct 2012 08:12:17 +0200
To:	bug-DBD-CSV [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Tue, 9 Oct 2012 13:30:42 -0400, "Benjamin Booth via RT" <bug-DBD-CSV@rt.cpan.org> wrote: Show quoted text

> DBD::CSV::st execute failed: > Execution ERROR: Can't call method "getline" on an undefined value at > /Library/Perl/5.12/DBD/CSV.pm line 433. > . > > [for Statement "select * from stdin"] at /Users/bbooth/bin/dbdcsv line 98. > at /Users/bbooth/bin/dbdcsv line 98 > > I tracked down the problem to a bug in lines 424 and 434 of > DBD/CSV.pm: $tbl->{csv_csv_in}->getline should be changed to > $attrs->{csv_csv_in}->getline. After applying this change, > DBD::CSV now works for me.

Looks like you are right. Patched. Can you give me a test case for the coverage? Then I can make a release soonish. -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Wed Oct 10 02:12:30 2012 The RT System itself - Status changed from 'new' to 'open'

Wed Oct 10 19:22:19 2012 benwbooth [...] gmail.com - Correspondence added

CC:	BENBOOTH [...] cpan.org
Subject:	Re: [rt.cpan.org #80078] bug in DBD::CSV causes select to fail
Date:	Wed, 10 Oct 2012 16:22:06 -0700
To:	bug-DBD-CSV [...] rt.cpan.org
From:	Ben Booth <benwbooth [...] gmail.com>

Here is a test case. Thanks, Ben Booth

Message body is not shown because sender requested not to inline it.

On Oct 9, 2012, at 11:12 PM, h.m.brand@xs4all.nl via RT <bug-DBD-CSV@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=80078 > > > On Tue, 9 Oct 2012 13:30:42 -0400, "Benjamin Booth via RT" > <bug-DBD-CSV@rt.cpan.org> wrote: >

>> DBD::CSV::st execute failed: >> Execution ERROR: Can't call method "getline" on an undefined value at >> /Library/Perl/5.12/DBD/CSV.pm line 433. >> . >> >> [for Statement "select * from stdin"] at /Users/bbooth/bin/dbdcsv line 98. >> at /Users/bbooth/bin/dbdcsv line 98 >> >> I tracked down the problem to a bug in lines 424 and 434 of >> DBD/CSV.pm: $tbl->{csv_csv_in}->getline should be changed to >> $attrs->{csv_csv_in}->getline. After applying this change, >> DBD::CSV now works for me.

> > Looks like you are right. Patched. Can you give me a test case for the > coverage? Then I can make a release soonish. > > -- > H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ > using perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE > http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ > http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/ >

Thu Oct 11 03:23:29 2012 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #80078] bug in DBD::CSV causes select to fail
Date:	Thu, 11 Oct 2012 09:23:15 +0200
To:	bug-DBD-CSV [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Wed, 10 Oct 2012 19:22:20 -0400, "Ben Booth via RT" <bug-DBD-CSV@rt.cpan.org> wrote: Show quoted text

> Here is a test case.

Thanks, integrated in t/80_rt.t Patched and pushed. Will be in next release -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.17 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Sat Oct 13 11:42:07 2012 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'

Thu Jan 10 02:10:02 2013 HMBRAND [...] cpan.org - Fixed in 0.38 added

Thu Jan 10 02:10:02 2013 HMBRAND [...] cpan.org - Status changed from 'patched' to 'resolved'

Thu Jan 10 02:10:47 2013 HMBRAND [...] cpan.org - Fixed in 0.37 added

Thu Jan 10 02:10:47 2013 HMBRAND [...] cpan.org - Fixed in 0.38 deleted