Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Daemon-Control CPAN distribution.

Report information
The Basics
Id: 79709
Status: open
Priority: 0/
Queue: Daemon-Control
People
Owner: Nobody in particular
Requestors: WESAL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Sep 17 21:08:12 2012 WESAL [...] cpan.org - Ticket created
Subject: kill 0,0 is true (edge case)
Several places in D:C there is a check for ($pid && pid_running($pid) ). pid_running should be updated to handle the edge case for `kill 0,0` being true. ( do_restart currently does not check this but all other do_* actions do) Potential fix: sub pid_running { my ( $self ) = @_; $self->read_pid; - return 0 unless kill 0, $self->pid; + return 0 unless $pid && kill 0, $self->pid;
  Wed Oct 29 11:23:23 2014 SREZIC [...] cpan.org - Correspondence added
On 2012-09-17 21:08:12, WESAL wrote: Show quoted text
> Several places in D:C there is a check for ($pid && pid_running($pid) > ). > > pid_running should be updated to handle the edge case for `kill 0,0` > being true. > ( do_restart currently does not check this but all other do_* actions > do) > > Potential fix: > > sub pid_running { > my ( $self ) = @_; > > $self->read_pid; > > - return 0 unless kill 0, $self->pid; > + return 0 unless $pid && kill 0, $self->pid;
Current Daemon::Control has the following check in pid_running(): return 0 unless $self->pid >= 1; So I assume this ticket may be closed?
  Wed Oct 29 11:23:23 2014 The RT System itself - Status changed from 'new' to 'open'