Skip Menu |

This queue is for tickets about the Carp-Parse-Redact CPAN distribution.

Report information
The Basics
Id: 79678
Status: resolved
Priority: 0/
Queue: Carp-Parse-Redact

People
Owner: Nobody in particular
Requestors: AUBERTG [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Hi Kate, I'm opening a ticket to fix this warning in the logs: Use of uninitialized value $arguments_string in quotemeta at Carp/Parse/CallerInformation/Redacted.pm line 127. I'll create a branch off master for you to review. Guillaume
Hi Kate, I added the following commit to branch RT_79678: commit a4cc714fca5d22ecd6fe268da7c2541298b7b6c4 Author: Guillaume Aubert <aubertg@cpan.org> Date: Sun Sep 16 20:54:34 2012 -0400 (RT #79678) No need to redact arguments when there's none defined for the line. I checked and this passes tests correctly: guillaume@avalon:~/Documents/cpan/Carp-Parse-Redact$ prove -I ../Carp-Parse/lib/ -I lib -r t/ t/00-load.t .......................................................... 1/1 # Carp::Parse::Redact 1.1.1, Perl 5.014002, /usr/bin/perl t/00-load.t .......................................................... ok t/10-parse_stack_trace.t ............................................. ok t/11-parse_stack_trace-regexp.t ...................................... ok t/CallerInformation-Redacted/00-load.t ............................... 1/1 # Carp::Parse::CallerInformation::Redacted 1.1.1, Perl 5.014002, /usr/bin/perl t/CallerInformation-Redacted/00-load.t ............................... ok t/CallerInformation-Redacted/10-new.t ................................ ok t/CallerInformation-Redacted/20-get_line.t ........................... ok t/CallerInformation-Redacted/30-get_arguments_string.t ............... ok t/CallerInformation-Redacted/40-get_arguments_list.t ................. ok t/CallerInformation-Redacted/45-get_redacted_arguments_list.t ........ ok t/CallerInformation-Redacted/50-get_redacted_line.t .................. ok t/CallerInformation-Redacted/51-get_redacted_line-single_argument.t .. ok t/manifest.t ......................................................... ok t/module_versions.t .................................................. ok t/perlcritic.t ....................................................... ok t/pod-coverage.t ..................................................... ok t/pod.t .............................................................. ok All tests successful. Files=16, Tests=31, 7 wallclock secs ( 0.13 usr 0.03 sys + 3.11 cusr 0.42 csys = 3.69 CPU) Result: PASS Please let me know what you think! Thank you, Guillaume
Patch accepted, fixed in 1.1.3.