Bug #79673 for Moose: supply attribute name to builder methods

Sat Sep 15 22:09:02 2012 DAMI [...] cpan.org - Ticket created

Subject:

supply attribute name to builder methods

Sometimes several builder methods have a common behaviour (for example fetching a default value from some config); so the same builder method could serve for several attributes, it just needs to know which attribute is being built. Therefore I suggest that builder methods receive the attribute name as argument. By the way, the same could apply to 'default'. Example: has 'aaa' => (is => 'ro', builder => '_from_config'); has 'bbb' => (is => 'ro', builder => '_from_config'); sub _from_config { my ($self, $attribute_name) = @_; my $config = ...; return $config->{$attribute_name}; }

Mon Nov 12 11:24:16 2012 perl [...] toby.ink - Correspondence added

I vote: sub _from_config { my ($self, $meta_attribute) = @_; my $attribute_name = $meta_attribute->name; my $config = ...; return $config->{$attribute_name}; }

Mon Nov 12 11:24:17 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 12 11:27:41 2012 doy [...] tozt.net - Correspondence added

Subject:	Re: [rt.cpan.org #79673] supply attribute name to builder methods
Date:	Mon, 12 Nov 2012 10:27:28 -0600
To:	Toby Inkster via RT <bug-Moose [...] rt.cpan.org>
From:	Jesse Luehrs <doy [...] tozt.net>

On Mon, Nov 12, 2012 at 11:24:17AM -0500, Toby Inkster via RT wrote: Show quoted text

> Queue: Moose > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79673 > > > I vote: > > sub _from_config { > my ($self, $meta_attribute) = @_; > my $attribute_name = $meta_attribute->name; > my $config = ...; > return $config->{$attribute_name}; > }

No, metaobjects shouldn't be provided by the API unless explicitly asked for (via find_meta or the 'meta' method or whatever). -doy

Mon Nov 12 11:27:43 2012 perl [...] toby.ink - Correspondence added

Meh. Actually, for inlining purposes, the attribute name is probably easier.

Mon Nov 12 11:45:03 2012 perl [...] toby.ink - Correspondence added

Meh. On further thought, consider this: { package Person; has formal_name => ( is => 'ro', isa => 'Str', ); has informal_name => ( is => 'ro', isa => 'Str', lazy => 1, builder => 'formal_name', ); } Currently this works as a technique to default one attribute from another. But the change suggested in this issue would break it. If the builder method was passed a second parameter, then formal_name would be called as a setter. So the suggested change would break any code relying on the technique above. Perhaps nobody is relying on this technique. Perhaps mission control at NASA is relying on it. Who knows? An alternative would be for Moose to set a package variable $Moose::CURRENTLY_BUILDING_ATTRIBUTE to the name of the attribute being built. If the builder cares about the name of the attribute being built, it can check that package variable. It's not an especially elegant solution though. Perhaps the best way is... has 'aaa' => (is => 'ro', default => _from_config('aaa')); has 'bbb' => (is => 'ro', default => _from_config('bbb')); sub _from_config { my $attribute_name = shift; return sub { my ($self) = @_; my $config = ...; return $config->{$attribute_name}; }; }

Wed Aug 28 19:08:09 2013 DOY [...] cpan.org - Correspondence added

I don't think we really want to do this. I'll close the ticket in a bit unless anyone objects.

Sat Jan 25 18:09:54 2014 DROLSKY [...] cpan.org - Status changed from 'open' to 'rejected'