Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SmokeRunner-Multi CPAN distribution.

Report information
The Basics
Id: 79665
Status: resolved
Priority: 0/
Queue: SmokeRunner-Multi

People
Owner: Nobody in particular
Requestors: yanick+cpan [...] babyl.dyndns.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Run with the perl interpreter the test was invoked with
script/smokerunner-multi uses '/usr/bin/perl' in the shebang line, which causes problems when it's built and installed for a perl installed elsewhere. So I changed the test to explicitly uses $^X. Patch attached. And I saw in the other bug report that you are looking for a new maintainer for the module. If you want, I'm willing to take over. :-)
Subject: 0001-Run-with-the-perl-interpreter-the-test-was-invoked-w.patch
From 3bef2c2e07550184eee57d93ad7ea47d03e5574e Mon Sep 17 00:00:00 2001 From: Yanick Champoux <yanick@babyl.dyndns.org> Date: Sat, 15 Sep 2012 14:26:00 -0400 Subject: [PATCH] Run with the perl interpreter the test was invoked with script/smokerunner-multi uses '/usr/bin/perl' in the shebang line, which causes problems when it's built and installed for a perl installed elsewhere. So I changed the test to explicitly uses $^X. --- t/smokerunner-multi.t | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/t/smokerunner-multi.t b/t/smokerunner-multi.t index 4f1a6ed..d34d4ba 100644 --- a/t/smokerunner-multi.t +++ b/t/smokerunner-multi.t @@ -27,7 +27,7 @@ my $script = File::Spec->catfile( 'script', 'smokerunner-multi' ); HELP: { - my $cmd = Test::Command->new( cmd => [ $script, 'help' ] ); + my $cmd = Test::Command->new( cmd => [ $^X, $script, 'help' ] ); exit_is_num( $cmd, 0, 'help command exits with 0' ); stdout_like( $cmd, qr/accepts the following commands/, @@ -38,7 +38,7 @@ HELP: LIST: { - my $cmd = Test::Command->new( cmd => [ $script, 'list' ] ); + my $cmd = Test::Command->new( cmd => [ $^X, $script, 'list' ] ); exit_is_num( $cmd, 0, 'list command exits with 0' ); stdout_like( $cmd, qr/set1\s+\|\s+\|\s+never/, @@ -54,7 +54,7 @@ LIST: skip 'These tests require that prove be in the PATH.', 3 unless which('prove'); - my $cmd = Test::Command->new( cmd => [ $script, 'run' ] ); + my $cmd = Test::Command->new( cmd => [ $^X, $script, 'run' ] ); exit_is_num( $cmd, 0, 'run command exits with 0' ); stdout_is_eq( $cmd, '', -- 1.7.4.1
Subject: Re: [rt.cpan.org #79665] [PATCH] Run with the perl interpreter the test was invoked with
Date: Sat, 15 Sep 2012 14:04:38 -0500 (CDT)
To: Yanick Champoux via RT <bug-SmokeRunner-Multi [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
On Sat, 15 Sep 2012, Yanick Champoux via RT wrote: Show quoted text
> Sat Sep 15 14:34:07 2012: Request 79665 was acted upon. > Transaction: Ticket created by YANICK > Queue: SmokeRunner-Multi > Subject: [PATCH] Run with the perl interpreter the test was invoked with > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: yanick+cpan@babyl.dyndns.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79665 > > > > script/smokerunner-multi uses '/usr/bin/perl' in the shebang line, > which causes problems when it's built and installed for a perl > installed elsewhere. So I changed the test to explicitly uses $^X. > > Patch attached. > > And I saw in the other bug report that you are looking for a new > maintainer for the module. If you want, I'm willing to take over. :-)
I'm happy to give you ownership of this. I've been using Jenkins for a while. What's your PAUSE id? -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
Subject: Re: [rt.cpan.org #79665] [PATCH] Run with the perl interpreter the test was invoked with
Date: Sat, 15 Sep 2012 15:16:43 -0400
To: bug-SmokeRunner-Multi [...] rt.cpan.org
From: Yanick Champoux <yanick [...] babyl.dyndns.org>
On 12-09-15 03:04 PM, autarch@urth.org via RT wrote: Show quoted text
> I'm happy to give you ownership of this. I've been using Jenkins for a > while.
I'm also using Jenkins most of the time. But now I'm having fun with trying to smoke all of Dancer's plugins and... it's not as trivial as it sounds. Of all the smoking modules, SR::M seems to the most promising for the bunch, hence the install, hence the catch of the bug, hence the report, hence the... new maintainership, I guess. Hmm, I have the feeling I've been had, somewhere in the middle in there. ;-) Show quoted text
> What's your PAUSE id?
YANICK. And thanks! Joy, `/anick
Subject: Re: [rt.cpan.org #79665] [PATCH] Run with the perl interpreter the test was invoked with
Date: Sat, 15 Sep 2012 14:44:56 -0500 (CDT)
To: "yanick [...] babyl.dyndns.org via RT" <bug-SmokeRunner-Multi [...] rt.cpan.org>
From: Dave Rolsky <autarch [...] urth.org>
On Sat, 15 Sep 2012, yanick@babyl.dyndns.org via RT wrote: Show quoted text
> Queue: SmokeRunner-Multi > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79665 > > > On 12-09-15 03:04 PM, autarch@urth.org via RT wrote:
>> I'm happy to give you ownership of this. I've been using Jenkins for a >> while.
> > I'm also using Jenkins most of the time. But now I'm having fun with > trying to smoke all of Dancer's plugins and... it's not as trivial as it > sounds. Of all the smoking modules, SR::M seems to the most promising > for the bunch, hence the install, hence the catch of the bug, hence the > report, hence the... new maintainership, I guess. Hmm, I have the > feeling I've been had, somewhere in the middle in there. ;-) >
>> What's your PAUSE id?
> > YANICK.
It's all yours. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/
Thanks! Patched and v0.17 is on its way to CPAN.