Skip Menu |

This queue is for tickets about the Module-Metadata CPAN distribution.

Maintainer(s)' notes

Attention bug reporters: issues MUST include the version of Module::Metadata that you are running that exhibit the stated symptoms. thank you!

Report information
The Basics
Id: 79656
Status: resolved
Priority: 0/
Queue: Module-Metadata
People
Owner: Nobody in particular
Requestors: NEILB [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.000011
Fixed in: (no value)

History Show all quoted text
  Fri Sep 14 17:24:52 2012 NEILB [...] cpan.org - Ticket created
Subject: Any pod after __END__ is ignored
If a module has all of its pod after __END__ then Module::Metadata reports that there's no pod. For example, HTTP::Client has this, and when I try Module::Metadata on HTTP::Client, I get contains-pod = -1 pod = This is down to the following line in Module::Metadata: last if $line =~ /^__(?:DATA|END)__$/; If I comment out this line, then I get: contains-pod = 7 pod = NAME,SYNOPSIS,DESCRIPTION,METHODS,EXAMPLE,SEE ALSO,AUTHOR,COPYRIGHT AND LICENSE A quick check turned up a good number of modules with all of their pod after __END__ I was going to offer to make the change and release, but noticed there's half a YAPC on the maintainer list for this module already!
  Thu Mar 21 02:07:14 2013 tokuhirom+cpan [...] gmail.com - Correspondence added
Hi, I'm got trouble in this issue, too. Can I send a patch to fix this issue? And, is this a main repo for this project? →→ https://github.com/dagolden/Module-Metadata
  Thu Mar 21 02:07:16 2013 The RT System itself - Status changed from 'new' to 'open'
  Thu Mar 21 12:12:49 2013 dagolden [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #79656] Any pod after __END__ is ignored
Date: Thu, 21 Mar 2013 12:11:59 -0400
To: bug-Module-Metadata [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
On Thu, Mar 21, 2013 at 2:07 AM, Tokuhiro Matsuno via RT <bug-Module-Metadata@rt.cpan.org> wrote: Show quoted text
> Queue: Module-Metadata > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79656 > > > Hi, I'm got trouble in this issue, too. > > Can I send a patch to fix this issue? > And, is this a main repo for this project? →→ https://github.com/dagolden/Module-Metadata
There is no main repo, really. The shadowcat repo is probably it: git://git.shadowcat.co.uk/p5sagit/Module-Metadata.git I think you have to be careful in parsing so that *POD* can be found after __END__ but other parsing (e.g. packages, $VERSION) does not continue after __END__. David -- David Golden <dagolden@cpan.org> Take back your inbox! → http://www.bunchmail.com/ Twitter/IRC: @xdg
  Tue Apr 30 03:03:47 2013 tokuhirom+cpan [...] gmail.com - Correspondence added
I pushed proposed patch. Could you review and merge it? http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit/Module-Metadata.git;a=commitdiff;h=e530a2cd55786d11150551b9b25534113507c4b5 On Thu Mar 21 12:12:49 2013, DAGOLDEN wrote: Show quoted text
> On Thu, Mar 21, 2013 at 2:07 AM, Tokuhiro Matsuno via RT > <bug-Module-Metadata@rt.cpan.org> wrote:
> > Queue: Module-Metadata > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79656 > > > > > Hi, I'm got trouble in this issue, too. > > > > Can I send a patch to fix this issue? > > And, is this a main repo for this project? →→
> https://github.com/dagolden/Module-Metadata > > There is no main repo, really. The shadowcat repo is probably it: > git://git.shadowcat.co.uk/p5sagit/Module-Metadata.git > > I think you have to be careful in parsing so that *POD* can be found > after __END__ but other parsing (e.g. packages, $VERSION) does not > continue after __END__. > > David >
  Sun May 05 00:39:08 2013 ether [...] cpan.org - Correspondence added
Merged; release pending.
  Sun May 05 00:39:08 2013 ether [...] cpan.org - Status changed from 'open' to 'patched'
  Sun May 05 00:59:20 2013 ether [...] cpan.org - Correspondence added
released in 1.000012
  Sun May 05 00:59:21 2013 ether [...] cpan.org - Status changed from 'patched' to 'resolved'