Bug #79343 for POE-Component-IRC: Possible encoding bug in POE::Component::IRC::Plugin::Logger

Hello. I think There are actually two bugs, one described by original report and one related. Bug #1: POE::Component::IRC::Plugin::Logger modifies data that other plugins will be working with. This happens due to writing into alias. Example (there are several): for my $chan (@{ $channels }) { $chan = decode_irc($chan); Bug #2: POE::Component::IRC::Plugin::Logger attempts to decode already decoded data. This bug I have discovered while investigating the first one. If the data is sent to irc as: $irc->yield('privmsg', $recipient, $text); and $recipient and $text are unicode characters, then S_bot_* handlers will receive the data as characters too. Attempting to apply decode_irc (in _normalize) to this data results in data being not logged (completely silent crash, unless your $irc has plugin_debug enabled). The following patch attempts to fix both of these issues by adding using local variables instead of writing into aliases, and by introducing a parameter to _normalize to conditionally turn off decoding. diff --git a/lib/POE/Component/IRC/Plugin/Logger.pm b/lib/POE/Component/IRC/Plugin/Logger.pm index e6a90a0..934bf75 100644 --- a/lib/POE/Component/IRC/Plugin/Logger.pm +++ b/lib/POE/Component/IRC/Plugin/Logger.pm @@ -119,8 +119,8 @@ sub S_ctcp_action { $self->_log_entry($sender, action => $sender, $msg); } else { - $recipient = decode_irc($recipient); - $self->_log_entry($recipient, action => $sender, $msg); + my $decoded_recipient = decode_irc($recipient); + $self->_log_entry($decoded_recipient, action => $sender, $msg); } } return PCI_EAT_NONE; @@ -137,8 +137,8 @@ sub S_notice { $self->_log_entry($sender, notice => $sender, $msg); } else { - $target = decode_irc($target); - $self->_log_entry($target, notice => $sender, $msg); + my $decoded_target = decode_irc($target); + $self->_log_entry($decoded_target, notice => $sender, $msg); } } return PCI_EAT_NONE; @@ -148,10 +148,9 @@ sub S_notice { sub S_bot_action { my ($self, $irc) = splice @_, 0, 2; my $recipients = ${ $_[0] }; - my $msg = $self->_normalize(${ $_[1] }); + my $msg = $self->_normalize(${ $_[1] }, 1); for my $recipient (@{ $recipients }) { - $recipient = decode_irc($recipient); $self->_log_entry($recipient, action => $irc->nick_name(), $msg); } return PCI_EAT_NONE; @@ -160,7 +159,7 @@ sub S_bot_action { sub S_bot_msg { my ($self, $irc) = splice @_, 0, 2; my $recipients = ${ $_[0] }; - my $msg = $self->_normalize(${ $_[1] }); + my $msg = $self->_normalize(${ $_[1] }, 1); for my $recipient (@{ $recipients }) { $self->_log_entry($recipient, privmsg => $irc->nick_name(), $msg); @@ -171,10 +170,9 @@ sub S_bot_msg { sub S_bot_public { my ($self, $irc) = splice @_, 0, 2; my $channels = ${ $_[0] }; - my $msg = $self->_normalize(${ $_[1] }); + my $msg = $self->_normalize(${ $_[1] }, 1); for my $chan (@{ $channels }) { - $chan = decode_irc($chan); $self->_log_entry($chan, privmsg => $irc->nick_name(), $msg); } return PCI_EAT_NONE; @@ -183,10 +181,9 @@ sub S_bot_public { sub S_bot_notice { my ($self, $irc) = splice @_, 0, 2; my $targets = ${ $_[0] }; - my $msg = $self->_normalize(${ $_[1] }); + my $msg = $self->_normalize(${ $_[1] }, 1); for my $target (@{ $targets }) { - $target = decode_irc($target); $self->_log_entry($target, notice => $irc->nick_name(), $msg); } return PCI_EAT_NONE; @@ -228,8 +225,8 @@ sub S_nick { my $channels = ${ $_[2] }; for my $chan (@{ $channels }) { - $chan = decode_irc($chan); - $self->_log_entry($chan, nick_change => $old_nick, $new_nick); + my $decoded_chan = decode_irc($chan); + $self->_log_entry($decoded_chan, nick_change => $old_nick, $new_nick); } return PCI_EAT_NONE; } @@ -252,8 +249,8 @@ sub S_public { my $msg = $self->_normalize(${ $_[2] }); for my $chan (@{ $channels }) { - $chan = decode_irc($chan); - $self->_log_entry($chan, privmsg => $sender, $msg); + my $chan_decoded = decode_irc($chan); + $self->_log_entry($chan_decoded, privmsg => $sender, $msg); } return PCI_EAT_NONE; } @@ -265,8 +262,8 @@ sub S_quit { my $channels = ${ $_[2] }; for my $chan (@{ $channels }) { - $chan = decode_irc($chan); - $self->_log_entry($chan, quit => $quitter, "$user\@$host", $msg); + my $chan_decoded = decode_irc($chan); + $self->_log_entry($chan_decoded, quit => $quitter, "$user\@$host", $msg); } return PCI_EAT_NONE; } @@ -405,8 +402,8 @@ sub _open_log { } sub _normalize { - my ($self, $line) = @_; - $line = decode_irc($line); + my ($self, $line, $skip_decode) = @_; + $line = decode_irc($line) unless $skip_decode; $line = strip_color($line) if $self->{Strip_color}; $line = strip_formatting($line) if $self->{Strip_formatting}; return $line;