Skip Menu |

This queue is for tickets about the Net-Syslogd CPAN distribution.

Report information
The Basics
Id: 79275
Status: resolved
Priority: 0/
Queue: Net-Syslogd

People
Owner: Nobody in particular
Requestors: MICHIELB [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Please make advanced tests timeout
I operate a 'smoker' - an automated system that downloads all new CPAN modules, tests them and submit results back to cpantesters. Your module has a prompt where it asks if you want to run extended tests, this prompt does not time out, meaning my smoker stops. Would you be willing to add a timeout for this question, where you assume No, after 60 seconds? For example the Mail::IMAPClient module has a similar setup in their Makefile.PL - https://www.metacpan.org/source/PLOBBES/Mail-IMAPClient-3.32/Makefile.PL -- Mike
Subject: Re: [rt.cpan.org #79275] Please make advanced tests timeout
Date: Wed, 29 Aug 2012 08:28:58 -0400
To: bug-Net-Syslogd [...] rt.cpan.org
From: Vince <vinsworldcom [...] gmail.com>
Will do next week. On Aug 29, 2012 2:59 AM, "Michiel Beijen via RT" < bug-Net-Syslogd@rt.cpan.org> wrote: Show quoted text
> Wed Aug 29 02:59:23 2012: Request 79275 was acted upon. > Transaction: Ticket created by MICHIELB > Queue: Net-Syslogd > Subject: Please make advanced tests timeout > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: MICHIELB@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79275 > > > > I operate a 'smoker' - an automated system that downloads all new CPAN > modules, tests them and submit results back to cpantesters. > > Your module has a prompt where it asks if you want to run extended > tests, this prompt does not time out, meaning my smoker stops. > > Would you be willing to add a timeout for this question, where you > assume No, after 60 seconds? > > For example the Mail::IMAPClient module has a similar setup in their > Makefile.PL - > https://www.metacpan.org/source/PLOBBES/Mail-IMAPClient-3.32/Makefile.PL > > -- > Mike >
On Wed Aug 29 02:59:23 2012, MICHIELB wrote: Show quoted text
> I operate a 'smoker' - an automated system that downloads all new CPAN > modules, tests them and submit results back to cpantesters. > > Your module has a prompt where it asks if you want to run extended > tests, this prompt does not time out, meaning my smoker stops. > > Would you be willing to add a timeout for this question, where you > assume No, after 60 seconds? > > For example the Mail::IMAPClient module has a similar setup in their > Makefile.PL - > https://www.metacpan.org/source/PLOBBES/Mail-IMAPClient-
3.32/Makefile.PL Show quoted text
> > -- > Mike
I develop Perl on Windows and the example you provided using alarm() does not work on Windows (Strawberry or ActiveState, not sure about cygwin) as Windows doesn't implement signals. I looked at Term::ReadKey which does work on Windows, but has a very low pass/fail ratio (12/147 - http://search.cpan.org/~kjalb/TermReadKey- 2.14/) and I'm loathe to require a module that has questionable success for a simple prompt in a test. Does your smoke test machine run a linux flavor? I could maybe put the alarm() test in if Windows just ignores it and yields the same results as now (no timeout) and if it will resolve the timeout on linux based systems. I have this no timeout prompt in 3 modules on CPAN up for over 2 years. I implemented my prompt based on what was in another CPAN module so I know others would have this issue. Strange this is the first time I've received this request. Have you looked into setting up 'distroprefs' to auto-respond to prompts during the build process? I've installed a few modules that prompt for some input during the make, no doubt they would hang your smoke tester also. cheers.
Subject: Re: [rt.cpan.org #79275] Please make advanced tests timeout
Date: Tue, 4 Sep 2012 10:28:06 +0200
To: bug-Net-Syslogd [...] rt.cpan.org
From: Michiel Beijen <michiel.beijen [...] gmail.com>
Thanks for your answer, and for looking into this. You really should not start introducing a new dependency. ExtUtils::MakeMaker (which you already use) has a feature built-in that does prompting which will understand if you run interactively or not. Please find attached a patched test.pl. Maybe you can consider this one? -- Mike

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #79275] Please make advanced tests timeout
Date: Tue, 4 Sep 2012 10:31:02 +0200
To: bug-Net-Syslogd [...] rt.cpan.org
From: Michiel Beijen <michiel.beijen [...] gmail.com>
By the way, my smoker runs Windows and uses Strawberry Perl.
Subject: Re: [rt.cpan.org #79275] Please make advanced tests timeout
Date: Tue, 4 Sep 2012 08:36:36 -0400
To: bug-Net-Syslogd [...] rt.cpan.org
From: Vince <vin [...] vinsworld.com>
On Tue, Sep 4, 2012 at 4:28 AM, michiel.beijen@gmail.com via RT <bug-Net-Syslogd@rt.cpan.org> wrote: Show quoted text
> Queue: Net-Syslogd > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79275 > > > Thanks for your answer, and for looking into this. You really should > not start introducing a new dependency. ExtUtils::MakeMaker (which you > already use) has a feature built-in that does prompting which will > understand if you run interactively or not. Please find attached a > patched test.pl. > > Maybe you can consider this one? > -- > Mike >
I appreciate the tip about EU::MM and 'prompt()'! Glad to see your smoke tester also runs Strawberry Perl on Windows - the same platform I use and develop on. I sometimes feel at a disadvantage as most users / developers seem to be running a *nix variant. In any case ... I tested your updated test.pl and it works fine. Although, it always prompts me - I'm not sure how 'prompt()' is determining whether or not it's interactive and how to simulate that - I tried with 'dmake test' and 'dmake disttest' and both prompted and waited for input. Do you have any way of verifying this will work as intended with your automated smoke tester? If we can get a solution, I'll update both of my recently re-released updated modules (N::Syslogd, N::SNMPTrapd) with the new method. cheers.
Version 0.07 now uploaded changes the prompt in advanced tests (test.pl) to use EU::MM and 'prompt()'. Also corrected in Net::SNMPTrapd (0.07).
Subject: Re: [rt.cpan.org #79275] Please make advanced tests timeout
Date: Mon, 10 Sep 2012 11:15:38 +0200
To: bug-Net-Syslogd [...] rt.cpan.org
From: Michiel Beijen <michiel.beijen [...] gmail.com>
Hi Michael, On Fri, Sep 7, 2012 at 4:12 PM, Michael Vincent via RT <bug-Net-Syslogd@rt.cpan.org> wrote: Show quoted text
> Version 0.07 now uploaded changes the prompt in advanced tests (test.pl) > to use EU::MM and 'prompt()'. > > Also corrected in Net::SNMPTrapd (0.07).
It works perfectly now, thanks a lot! -- Michiel
Subject: Re: [rt.cpan.org #79275] Please make advanced tests timeout
Date: Mon, 10 Sep 2012 09:20:37 -0400
To: bug-Net-Syslogd [...] rt.cpan.org
From: Vince <vin [...] vinsworld.com>
Awesome - I tested 'dmake disttest' while setting the PERL_MM_USE_DEFAULT environment variable and it seemed to work for me - I assumed that's how your automated smoke tester works. Glad to hear it's fixed. On Mon, Sep 10, 2012 at 9:16 AM, michiel.beijen@gmail.com via RT <bug-Net-Syslogd@rt.cpan.org> wrote: Show quoted text
> Queue: Net-Syslogd > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79275 > > > Hi Michael, > > On Fri, Sep 7, 2012 at 4:12 PM, Michael Vincent via RT > <bug-Net-Syslogd@rt.cpan.org> wrote: >
>> Version 0.07 now uploaded changes the prompt in advanced tests (test.pl) >> to use EU::MM and 'prompt()'. >> >> Also corrected in Net::SNMPTrapd (0.07).
> > It works perfectly now, thanks a lot! > -- > Michiel >