Bug #79181 for DBIx-Class-InflateColumn-Boolean: Fails with Contextual::Return >= 0.004004

Fri Aug 24 00:23:30 2012 ANDK [...] cpan.org - Ticket created

CC:	DCONWAY [...] cpan.org
Subject:	Fails with Contextual::Return >= 0.004004

As per subject. Sample fail report: http://www.cpantesters.org/cpan/report/23081644 HTH&&Regards,

Fri Aug 24 01:17:41 2012 damian [...] conway.org - Correspondence added

CC:	DCONWAY [...] cpan.org
Subject:	Re: [rt.cpan.org #79181] Fails with Contextual::Return >= 0.004004
Date:	Fri, 24 Aug 2012 15:16:53 +1000
To:	bug-DBIx-Class-InflateColumn-Boolean [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Noted. Thanks. Will address if I can ever get a working 5.17.X on my system. :-( Damian

Fri Aug 24 01:17:43 2012 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 24 14:39:23 2012 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org, DCONWAY [...] cpan.org
Subject:	Re: [rt.cpan.org #79181] Fails with Contextual::Return >= 0.004004
Date:	Fri, 24 Aug 2012 20:39:05 +0200
To:	bug-DBIx-Class-InflateColumn-Boolean [...] rt.cpan.org
From:	Andreas Koenig <andreas.koenig.7os6VVqR [...] franz.ak.mind.de>

"damian@conway.org via RT" <bug-DBIx-Class-InflateColumn-Boolean@rt.cpan.org> writes: Show quoted text

> Noted. Thanks. > > Will address if I can ever get a working 5.17.X on my system. :-(

Not related to 5.17, I just reproduced same discontinued behaviour with 5.16.1 and 5.14.2. -- andreas

Thu Oct 04 09:23:48 2012 bitcard [...] faxm0dem.org - Correspondence added

From:

bitcard [...] faxm0dem.org

Hi, this is just to report the same problem. I tried to track it down in the diff of Contextual/Return.pm, but nothing obvious jumped at me. Is this something that will be solved soon? Thanks!

Thu Oct 04 10:52:43 2012 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #79181] Fails with Contextual::Return >= 0.004004
Date:	Thu, 4 Oct 2012 16:51:49 +0200
To:	bug-DBIx-Class-InflateColumn-Boolean [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Show quoted text

> this is just to report the same problem. I tried to track it down in the > diff of Contextual/Return.pm, but nothing obvious jumped at me. > > Is this something that will be solved soon?

I just uploaded a new version that appears to solve the problem. Please allow an hour or two for CPAN to propagate it and then try Contextual::Return v0.4.6 to see if it addresses the issue. Thanks for reraising the problem. Damian

Fri Oct 05 06:53:12 2012 bitcard [...] faxm0dem.org - Correspondence added

From:

bitcard [...] faxm0dem.org

Hi, Thanks for the quick update. However, the tests still fail (but differently): -- DBIx-Class-InflateColumn-Boolean-0.001001-7Vli4y(0)$ make test Skip blib/lib/DBIx/Class/InflateColumn/Boolean.pm (unchanged) PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01-boolean.t t/pod-coverage.t t/p od.t t/00-load.t ....... 1/1 # Testing DBIx::Class::InflateColumn::Boolean 0.001001, Perl 5.014002, /usr/bin/perl t/00-load.t ....... ok t/01-boolean.t .... 1/30 DBIx::Class::Relationship::CascadeActions::update(): [S QL::Abstract::_SWITCH_refkind] Fatal: no dispatch entry for Contextual::Return:: ValueREF at t/01-boolean.t line 70 # Looks like you planned 30 tests but ran 24. # Looks like your test exited with 2 just after 24. t/01-boolean.t .... Dubious, test returned 2 (wstat 512, 0x200) Failed 6/30 subtests t/pod-coverage.t .. ok t/pod.t ........... ok -- What I don't understand is why 'prove -vbl t/01-boolean.t' fails on the following error: -- t/01-boolean.t .. DBIx::Class::Schema::throw_exception(): Can't locate Contextua l/Return.pm in @INC (@INC contains: t/lib /home/fwernli/.cpan/build/DBIx-Class-I nflateColumn-Boolean-0.001001-7Vli4y/lib /home/fwernli/.cpan/build/DBIx-Class-In flateColumn-Boolean-0.001001-7Vli4y/blib/lib /home/fwernli/.cpan/build/DBIx-Clas s-InflateColumn-Boolean-0.001001-7Vli4y/blib/arch /etc/perl /usr/local/lib/perl/ 5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/per l/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl) at /home/fwernli/.cpan/bui ld/DBIx-Class-InflateColumn-Boolean-0.001001-7Vli4y/lib/DBIx/Class/InflateColumn /Boolean.pm line 8. BEGIN failed--compilation aborted at /home/fwernli/.cpan/build/DBIx-Class-Inflat eColumn-Boolean-0.001001-7Vli4y/lib/DBIx/Class/InflateColumn/Boolean.pm line 8. Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm line 150. at t/01-boolean.t line 9 Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155 Compilation failed in require at t/01-boolean.t line 9. B --

Fri Oct 05 07:00:59 2012 damian [...] conway.org - Correspondence added

CC:	ANDK [...] cpan.org, DCONWAY [...] cpan.org
Subject:	Re: [rt.cpan.org #79181] Fails with Contextual::Return >= 0.004004
Date:	Fri, 5 Oct 2012 13:00:01 +0200
To:	bug-DBIx-Class-InflateColumn-Boolean [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Fabien Wernli wrote: Show quoted text

> Thanks for the quick update. > However, the tests still fail (but differently):

None of these failing tests seem to involve Contextual::Return, as far as I can see. Damian

Fri Oct 05 07:34:12 2012 bitcard [...] faxm0dem.org - Correspondence added

From:

bitcard [...] faxm0dem.org

Well, it has to: all other things identical, they succeed as soon as I switch to 0.004003: =============== fwernli@1349436710/DBIx-Class-InflateColumn-Boolean-0.001001-7Vli4y(0)$ PERL5LIB=../Contextual-Return-0.004003-8dsQiS/blib/lib:$PERL5LIB make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01-boolean.t t/pod-coverage.t t/p od.t t/00-load.t ....... 1/1 # Testing DBIx::Class::InflateColumn::Boolean 0.001001, Perl 5.014002, /usr/bin/perl t/00-load.t ....... ok t/01-boolean.t .... ok t/pod-coverage.t .. ok t/pod.t ........... ok All tests successful. Files=4, Tests=33, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.26 cusr 0.03 csy s = 0.32 CPU) Result: PASS =========== fwernli@1349436717/DBIx-Class-InflateColumn-Boolean-0.001001-7Vli4y(0)$ PERL5LIB=../Contextual-Return-0.004006-Tx7sJy/blib/lib:$PERL5LIB make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t t/01-boolean.t t/pod-coverage.t t/p od.t t/00-load.t ....... 1/1 # Testing DBIx::Class::InflateColumn::Boolean 0.001001, Perl 5.014002, /usr/bin/perl t/00-load.t ....... ok t/01-boolean.t .... 1/30 DBIx::Class::Relationship::CascadeActions::update(): [S QL::Abstract::_SWITCH_refkind] Fatal: no dispatch entry for Contextual::Return:: ValueREF at t/01-boolean.t line 70 # Looks like you planned 30 tests but ran 24. # Looks like your test exited with 2 just after 24. t/01-boolean.t .... Dubious, test returned 2 (wstat 512, 0x200) Failed 6/30 subtests t/pod-coverage.t .. ok t/pod.t ........... ok Test Summary Report ------------------- t/01-boolean.t (Wstat: 512 Tests: 24 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 30 tests but ran 24. Files=4, Tests=27, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.27 cusr 0.04 csy s = 0.34 CPU) Result: FAIL Failed 1/4 test programs. 0/27 subtests failed. make: *** [test_dynamic] Error 255 --

Fri Oct 05 18:08:45 2012 damian [...] conway.org - Correspondence added

CC:	ANDK [...] cpan.org, DCONWAY [...] cpan.org
Subject:	Re: [rt.cpan.org #79181] Fails with Contextual::Return >= 0.004004
Date:	Fri, 5 Oct 2012 23:07:52 +0100
To:	bug-DBIx-Class-InflateColumn-Boolean [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

After considerable further investigation, the problem is that SQL::Abstract::_refkind() uses Scalar::Util::blessed() to determine when its $data parameter contains a blessed object. But, as of Contextual::Return v0.4.4, Scalar::Util::blessed() only reports Contextual::Return::Value objects as being blessed if the CRV object has a handler that itself produces a blessed object. That is, as of v0.4.4 Contextual::Return improves its mimicry of a return *value* by no longer acting like an object in its own right; that is: contextual return value objects no longer directly respond to blessed(), but instead apply the blessed() test to the values produced by the various handlers that were specified for the original return value. This change means that I have had to add a new BLESSED{...} handler to allow users of Contextual::Return to specify what blessed() should return when applied to a specific Contextual::Return::Value. I just uploaded v0.4.7 with this new feature. Then the handlers used in DBIx::Class::InflateColumn::Boolean::register_column() will have to be augmented with BLESSED {...} handlers, to reinstate (a simulation of) the old behaviour. The attached patch makes the necessary changes to Boolean.pm. Hope this helps, Damian

Message body is not shown because sender requested not to inline it.

Tue Oct 09 03:48:30 2012 bitcard [...] faxm0dem.org - Correspondence added

From:

bitcard [...] faxm0dem.org

Hi, Thanks for your quick action. Does this mean you will soon release a new version of DBIx::Class::InflateColumn::Boolean reflecting these changes? Thanks!

Wed Oct 10 02:45:16 2012 GRAF [...] cpan.org - Correspondence added

RT-Send-CC:

bitcard [...] faxm0dem.org, damian [...] conway.org

Thanks Damian, I will try to find some time to check this out and release real soon.

Wed Oct 10 18:19:43 2012 GRAF [...] cpan.org - Correspondence added

RT-Send-CC:

bitcard [...] faxm0dem.org, damian [...] conway.org

Just uploaded 0.00200.

Wed Oct 10 18:19:44 2012 GRAF [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #79181 for DBIx-Class-InflateColumn-Boolean: Fails with Contextual::Return >= 0.004004

Preferred bug tracker