Skip Menu |

This queue is for tickets about the Sendmail-AccessDB CPAN distribution.

Report information
The Basics
Id: 79131
Status: resolved
Priority: 0/
Queue: Sendmail-AccessDB

People
Owner: Nobody in particular
Requestors: STEPHANJ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.01
Fixed in: (no value)



Subject: Make the Module check for Qualifier Defaults
Hi, i added an patch for the testcase which shows that the Module currently doesnt respect defaults for the Qualifier f.e. doesnt check "Qualifier:". This is a mandatory feature in the Access.DB f.e. for specifying global connection limits. Additionally i added another patch which will add this feature to the Module. Regards, Stephan
Subject: AccessDB.patch
--- lib/Sendmail/AccessDB.pm.orig 2012-08-22 11:13:59.000000000 +0200 +++ lib/Sendmail/AccessDB.pm 2012-08-22 11:14:40.000000000 +0200 @@ -250,6 +250,8 @@ @check_list = ($address); } + push(@check_list, ''); + my %access; my $filename = $DB_FILE; @@ -262,6 +264,7 @@ -Filename => $filename or die "Cannot open file $filename: $! $BerkeleyDB::Error\n"; + foreach my $key (@check_list) { my $lookup = $key;
Subject: 03_functions.patch
--- t/03_functions.t.orig 2012-08-22 11:08:41.000000000 +0200 +++ t/03_functions.t 2012-08-22 11:12:33.000000000 +0200 @@ -1,7 +1,7 @@ # t/03_functions.t; test the basic functions $|++; -print "1..5 +print "1..7 "; my($test) = 1; @@ -19,6 +19,12 @@ { print "ok $test\n";}else{ print "not ok $test\n"; } $test++; +$friend = Sendmail::AccessDB::spam_friend('foo@bar.de'); +if ( (defined $friend) and ($friend eq 'FOE')) + { print "ok $test\n";}else{ print "not ok $test\n"; } +$test++; + + my $whitelisted = Sendmail::AccessDB::whitelisted('foo.test.example.com','type'=>'hostname'); if ( (defined $whitelisted) and ($whitelisted)) { print "ok $test\n" }else{ print "not ok $test\n"; } @@ -37,5 +43,11 @@ if ($wltwo) { print "ok $test\n" } else { print "not ok $test\n"; }; $test++; +my $should_be_skip = Sendmail::AccessDB::lookup('user@foo.bar.tld2','qualifier'=>'Qual','type'=>'mail'); +if ($should_be_skip eq "SKIP") { print "ok $test\n" } else { print "not ok $test\n"; }; +$test++; + + + # end of t/03_functions.t
Subject: Re: [rt.cpan.org #79131] Make the Module check for Qualifier Defaults
Date: Wed, 22 Aug 2012 09:37:36 -0400
To: bug-Sendmail-AccessDB [...] rt.cpan.org
From: Derek Balling <dredd [...] megacity.org>
I haven't been in a position where I can adequately test/support AccessDB.pm for quite some time. Since I see you've got a CPAN account, would you be interested in taking over support for it? It's obviously, as you might expect, a very low-maintenance module. I just don't have any Sendmail systems around any more that I can use for testing purposes, etc. D On Aug 22, 2012, at 5:19 AM, Stephan Jauernick via RT <bug-Sendmail-AccessDB@rt.cpan.org> wrote: Show quoted text
> Wed Aug 22 05:19:18 2012: Request 79131 was acted upon. > Transaction: Ticket created by STEPHANJ > Queue: Sendmail-AccessDB > Subject: Make the Module check for Qualifier Defaults > Broken in: 1.01 > Severity: (no value) > Owner: Nobody > Requestors: STEPHANJ@cpan.org > Status: patched > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > > > > Hi, > > i added an patch for the testcase which shows that the Module currently > doesnt respect defaults for the Qualifier f.e. doesnt check "Qualifier:". > > This is a mandatory feature in the Access.DB f.e. for specifying global > connection limits. > > Additionally i added another patch which will add this feature to the > Module. > > Regards, > Stephan > > > <AccessDB.patch><03_functions.patch>
Subject: Re: [rt.cpan.org #79131] Make the Module check for Qualifier Defaults
Date: Wed, 22 Aug 2012 15:41:38 +0200
To: <bug-sendmail-accessdb [...] rt.cpan.org>
From: Stephan Jauernick <info [...] stephan-jauernick.de>
Hi, If you are willing to do that i would do it. Am 22.08.2012 15:38, schrieb Derek J. Balling via RT: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > > > I haven't been in a position where I can adequately test/support > AccessDB.pm for quite some time. Since I see you've got a CPAN > account, would you be interested in taking over support for it? > > It's obviously, as you might expect, a very low-maintenance module. I > just don't have any Sendmail systems around any more that I can use > for testing purposes, etc. > > D > > > On Aug 22, 2012, at 5:19 AM, Stephan Jauernick via RT > <bug-Sendmail-AccessDB@rt.cpan.org> wrote: >
>> Wed Aug 22 05:19:18 2012: Request 79131 was acted upon. >> Transaction: Ticket created by STEPHANJ >> Queue: Sendmail-AccessDB >> Subject: Make the Module check for Qualifier Defaults >> Broken in: 1.01 >> Severity: (no value) >> Owner: Nobody >> Requestors: STEPHANJ@cpan.org >> Status: patched >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > >> >> >> Hi, >> >> i added an patch for the testcase which shows that the Module >> currently >> doesnt respect defaults for the Qualifier f.e. doesnt check >> "Qualifier:". >> >> This is a mandatory feature in the Access.DB f.e. for specifying >> global >> connection limits. >> >> Additionally i added another patch which will add this feature to >> the >> Module. >> >> Regards, >> Stephan >> >> >> <AccessDB.patch><03_functions.patch>
Subject: Re: [rt.cpan.org #79131] Make the Module check for Qualifier Defaults
Date: Wed, 22 Aug 2012 09:46:02 -0400
To: bug-Sendmail-AccessDB [...] rt.cpan.org
From: Derek Balling <dredd [...] megacity.org>
It's all yours. Maintain it in good health! :-) Cheers, D On Aug 22, 2012, at 9:41 AM, info via RT <bug-Sendmail-AccessDB@rt.cpan.org> wrote: Show quoted text
> Queue: Sendmail-AccessDB > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > > > Hi, > > If you are willing to do that i would do it. > > Am 22.08.2012 15:38, schrieb Derek J. Balling via RT:
>> <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > >> >> I haven't been in a position where I can adequately test/support >> AccessDB.pm for quite some time. Since I see you've got a CPAN >> account, would you be interested in taking over support for it? >> >> It's obviously, as you might expect, a very low-maintenance module. I >> just don't have any Sendmail systems around any more that I can use >> for testing purposes, etc. >> >> D >> >> >> On Aug 22, 2012, at 5:19 AM, Stephan Jauernick via RT >> <bug-Sendmail-AccessDB@rt.cpan.org> wrote: >>
>>> Wed Aug 22 05:19:18 2012: Request 79131 was acted upon. >>> Transaction: Ticket created by STEPHANJ >>> Queue: Sendmail-AccessDB >>> Subject: Make the Module check for Qualifier Defaults >>> Broken in: 1.01 >>> Severity: (no value) >>> Owner: Nobody >>> Requestors: STEPHANJ@cpan.org >>> Status: patched >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > >>> >>> >>> Hi, >>> >>> i added an patch for the testcase which shows that the Module >>> currently >>> doesnt respect defaults for the Qualifier f.e. doesnt check >>> "Qualifier:". >>> >>> This is a mandatory feature in the Access.DB f.e. for specifying >>> global >>> connection limits. >>> >>> Additionally i added another patch which will add this feature to >>> the >>> Module. >>> >>> Regards, >>> Stephan >>> >>> >>> <AccessDB.patch><03_functions.patch>
> >
Thanks! Am Mi 22. Aug 2012, 09:46:26, DREDD schrieb: Show quoted text
> It's all yours. Maintain it in good health! :-) > > Cheers, > D > > On Aug 22, 2012, at 9:41 AM, info via RT <bug-Sendmail- > AccessDB@rt.cpan.org> wrote: >
> > Queue: Sendmail-AccessDB > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > > > > > Hi, > > > > If you are willing to do that i would do it. > > > > Am 22.08.2012 15:38, schrieb Derek J. Balling via RT:
> >> <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > > >> > >> I haven't been in a position where I can adequately test/support > >> AccessDB.pm for quite some time. Since I see you've got a CPAN > >> account, would you be interested in taking over support for it? > >> > >> It's obviously, as you might expect, a very low-maintenance module.
> I
> >> just don't have any Sendmail systems around any more that I can use > >> for testing purposes, etc. > >> > >> D > >> > >> > >> On Aug 22, 2012, at 5:19 AM, Stephan Jauernick via RT > >> <bug-Sendmail-AccessDB@rt.cpan.org> wrote: > >>
> >>> Wed Aug 22 05:19:18 2012: Request 79131 was acted upon. > >>> Transaction: Ticket created by STEPHANJ > >>> Queue: Sendmail-AccessDB > >>> Subject: Make the Module check for Qualifier Defaults > >>> Broken in: 1.01 > >>> Severity: (no value) > >>> Owner: Nobody > >>> Requestors: STEPHANJ@cpan.org > >>> Status: patched > >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79131 > > >>> > >>> > >>> Hi, > >>> > >>> i added an patch for the testcase which shows that the Module > >>> currently > >>> doesnt respect defaults for the Qualifier f.e. doesnt check > >>> "Qualifier:". > >>> > >>> This is a mandatory feature in the Access.DB f.e. for specifying > >>> global > >>> connection limits. > >>> > >>> Additionally i added another patch which will add this feature to > >>> the > >>> Module. > >>> > >>> Regards, > >>> Stephan > >>> > >>> > >>> <AccessDB.patch><03_functions.patch>
> > > >
>
Module given to STEPHANJ for maintenance.