Skip Menu |

This queue is for tickets about the Data-Dump-Streamer CPAN distribution.

Report information
The Basics
Id: 79127
Status: resolved
Priority: 0/
Queue: Data-Dump-Streamer

People
Owner: Nobody in particular
Requestors: d.thomas [...] its.uq.edu.au
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.37



Subject: several tests FAIL with perl 5.17.3
RHEL5 t/globtest.t ........ 1/19 # Failed test 'data slots (glob/FORMAT)' # at t/test_helper.pl line 114. # Failed test 'data slots (ref/FORMAT)' # at t/test_helper.pl line 114. # Error: # data slots (blessed FORMAT) subtest Expected failed to return the expected result: # Expected Result # 1 = # format F = | # format F = # 2 = # vec($_,@#,@#) = @<< == @######### @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> | # vec($_,@#,@#) = @<< == @######### @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> # 3 ! # $off, $width, $bits, $val, $res * # $off, $width, $bits, $val, $res; # 4 = # vec($_,@#,@#) = @<< == @######### @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> | # vec($_,@#,@#) = @<< == @######### @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> # 5 ! # $off, $width, $bits, $val, $res * # $off, $width, $bits, $val, $res; # 6 = # . | # . # 7 = _EOF_FORMAT_ | _EOF_FORMAT_ Got <<'EXPECT'; $Thank_YSTH1 = bless( do{ local *F; my $F=<<'_EOF_FORMAT_'; $F=~s/^\s+# //mg; eval $F; die $F.$@ if $@; *F{FORMAT}; # format F = # vec($_,@#,@#) = @<< == @######### @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> # $off, $width, $bits, $val, $res; # vec($_,@#,@#) = @<< == @######### @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> # $off, $width, $bits, $val, $res; # . _EOF_FORMAT_ }, 'Thank::YSTH' ); EXPECT # Failed test 'data slots (blessed FORMAT)' # at t/test_helper.pl line 559. # Looks like you failed 3 tests of 19. t/globtest.t ........ Dubious, test returned 3 (wstat 768, 0x300) ... t/madness.t ......... 1/7 # Failed test '' # at t/test_helper.pl line 114. # Looks like you failed 1 test of 7. t/madness.t ......... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests t/madness_json.t .... 1/7 # Failed test '' # at t/test_helper.pl line 114. # Looks like you failed 1 test of 7. t/madness_json.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/7 subtests
On Tue Aug 21 21:46:53 2012, d.thomas@its.uq.edu.au wrote: Show quoted text
> RHEL5 > > t/globtest.t ........ 1/19 > # Failed test 'data slots (glob/FORMAT)' > # at t/test_helper.pl line 114. > > # Failed test 'data slots (ref/FORMAT)' > # at t/test_helper.pl line 114. > # Error: > # data slots (blessed FORMAT) subtest Expected failed to return the > expected result: > # Expected > Result > # 1 = # format F = > | > # format F = > # 2 = # vec($_,@#,@#) = @<< == @######### > @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> | > # > vec($_,@#,@#) = @<< == @#########
@>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Show quoted text
> # 3 ! # $off, $width, $bits, $val, $res > * > # $off, $width, $bits, $val, $res; > # 4 = # vec($_,@#,@#) = @<< == @######### > @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> | > # > vec($_,@#,@#) = @<< == @#########
@>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Show quoted text
> # 5 ! # $off, $width, $bits, $val, $res > * > # $off, $width, $bits, $val, $res; > # 6 = # . > | > # . > # 7 = _EOF_FORMAT_ > | > _EOF_FORMAT_ > Got <<'EXPECT'; > $Thank_YSTH1 = bless( do{ local *F; my $F=<<'_EOF_FORMAT_'; > $F=~s/^\s+# //mg; eval > $F; die $F.$@ if $@; *F{FORMAT}; > # format F = > # vec($_,@#,@#) = @<< == @######### > @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > # $off, $width, $bits, $val, $res; > # vec($_,@#,@#) = @<< == @######### > @>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> > # $off, $width, $bits, $val, $res; > # . > _EOF_FORMAT_ > }, 'Thank::YSTH' ); > > EXPECT > > # Failed test 'data slots (blessed FORMAT)' > # at t/test_helper.pl line 559. > # Looks like you failed 3 tests of 19. > t/globtest.t ........ Dubious, test returned 3 (wstat 768, 0x300) > ... > t/madness.t ......... 1/7 > # Failed test '' > # at t/test_helper.pl line 114. > # Looks like you failed 1 test of 7. > t/madness.t ......... Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/7 subtests > t/madness_json.t .... 1/7 > # Failed test '' > # at t/test_helper.pl line 114. > # Looks like you failed 1 test of 7. > t/madness_json.t .... Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/7 subtests
I fixed the format failures in perl commit 31c26a0ab02. The other failures are probably to do with PADLIST changes.
On Wed Aug 22 23:45:55 2012, SPROUT wrote: Show quoted text
> I fixed the format failures in perl commit 31c26a0ab02. The other > failures are probably to do > with PADLIST changes.
Actually, they have to do with CV stubs no longer carrying pads. Lo, a patch.
Subject: open_R8quFtJc.txt
Binary files Data-Dump-Streamer-2.34-39uVmd/lib/Data/Dump/Streamer.o and Data-Dump-Streamer-2.34-yhMVdp/lib/Data/Dump/Streamer.o differ diff -rup Data-Dump-Streamer-2.34-39uVmd/lib/Data/Dump/Streamer.pm Data-Dump-Streamer-2.34-yhMVdp/lib/Data/Dump/Streamer.pm --- Data-Dump-Streamer-2.34-39uVmd/lib/Data/Dump/Streamer.pm 2012-06-06 02:47:31.000000000 -0700 +++ Data-Dump-Streamer-2.34-yhMVdp/lib/Data/Dump/Streamer.pm 2012-08-22 23:16:29.000000000 -0700 @@ -3695,9 +3695,9 @@ sub _get_lexicals { } my $svo=B::svref_2object($cv); - my @pl_array = $svo->PADLIST->ARRAY; + my @pl_array = eval { $svo->PADLIST->ARRAY }; - my @name_obj = $pl_array[0]->ARRAY; + my @name_obj = eval { $pl_array[0]->ARRAY }; my %named; for my $i ( 0..$#name_obj ) {
On Thu Aug 23 02:18:23 2012, SPROUT wrote: Show quoted text
> On Wed Aug 22 23:45:55 2012, SPROUT wrote:
> > I fixed the format failures in perl commit 31c26a0ab02. The other > > failures are probably to do > > with PADLIST changes.
> > Actually, they have to do with CV stubs no longer carrying pads. > > Lo, a patch.
BTW, DDS already passes its tests with PadWalker installed, but this patch is still necessary for when PadWalker is absent.
On 2012-08-23 02:18:23, SPROUT wrote: Show quoted text
> On Wed Aug 22 23:45:55 2012, SPROUT wrote:
> > I fixed the format failures in perl commit 31c26a0ab02. The other > > failures are probably to do > > with PADLIST changes.
> > Actually, they have to do with CV stubs no longer carrying pads. > > Lo, a patch.
I created a pull request with your patch: https://github.com/demerphq/Data-Dump-Streamer/pull/4 Regards, Slaven
On 2013-12-29 15:09:07, SREZIC wrote: Show quoted text
> On 2012-08-23 02:18:23, SPROUT wrote:
> > On Wed Aug 22 23:45:55 2012, SPROUT wrote:
> > > I fixed the format failures in perl commit 31c26a0ab02. The other > > > failures are probably to do > > > with PADLIST changes.
> > > > Actually, they have to do with CV stubs no longer carrying pads. > > > > Lo, a patch.
> > I created a pull request with your patch: > https://github.com/demerphq/Data-Dump-Streamer/pull/4
Issue can be closed. Regards, Slaven