Skip Menu |

This queue is for tickets about the XML-Simple CPAN distribution.

Report information
The Basics
Id: 79117
Status: resolved
Priority: 0/
Queue: XML-Simple

People
Owner: grantm [...] cpan.org
Requestors: xenoterracide [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.22



Subject: File does not exist: t/desertnet.xml at t/3_Storable.t line 158.
Date: Tue, 21 Aug 2012 13:47:27 -0500
To: bugs-xml-simple [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
attaching build log cpanm (App::cpanminus) 1.5017 on perl 5.014002 built for x86_64-linux Work directory is /home/libdevel/.cpanm/work/1345573900.32447 You have make /usr/bin/make You have LWP 6.04 You have /bin/tar: tar (GNU tar) 1.23 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by John Gilmore and Jay Fenlason. You have /usr/bin/unzip Searching XML::Simple on cpanmetadb ... --> Working on XML::Simple Fetching https://gpan.hostgator.com/authors/id/G/GR/GRANTM/XML-Simple-2.20.tar.gz -> OK Unpacking XML-Simple-2.20.tar.gz Entering XML-Simple-2.20 Checking configure dependencies from META.yml Checking if you have ExtUtils::MakeMaker 6.31 ... Yes (6.62) Configuring XML-Simple-2.20 Running Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for XML::Simple Writing MYMETA.yml and MYMETA.json -> OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0.88 ... Yes (0.98) Checking if you have XML::SAX 0.15 ... Yes (0.99) Checking if you have XML::NamespaceSupport 1.04 ... Yes (1.11) Checking if you have XML::SAX::Expat 0 ... Yes (0.40) Building and testing XML-Simple-2.20 cp lib/XML/Simple/FAQ.pod blib/lib/XML/Simple/FAQ.pod cp lib/XML/Simple.pm blib/lib/XML/Simple.pm Manifying blib/man3/XML::Simple::FAQ.3 Manifying blib/man3/XML::Simple.3 PERL_DL_NONLAZY=1 /home/libdevel/perl5/perlbrew/perls/perl-5.14.2/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t # Package Version # perl 5.14.2 # XML::Simple 2.20 # Storable 2.27 # XML::Parser 2.41 # XML::SAX 0.99 # XML::NamespaceSupport 1.11 # XML::SAX::PurePerl 0.99 # XML::LibXML::SAX::Parser 2.0003 # XML::LibXML::SAX 2.0003 # XML::SAX::Expat 0.40 (default parser) t/0_Config.t ............ ok t/1_XMLin.t ............. ok t/2_XMLout.t ............ ok t/6_ObjIntf.t ........... ok t/7_SaxStuff.t .......... ok t/8_Namespaces.t ........ ok t/9_Strict.t ............ ok t/A_XMLParser.t ......... ok File does not exist: t/desertnet.xml at t/3_Storable.t line 158. # Looks like you planned 23 tests but ran 4. # Looks like your test exited with 2 just after 4. t/3_Storable.t .......... Dubious, test returned 2 (wstat 512, 0x200) Failed 19/23 subtests t/release-pod-syntax.t .. skipped: these tests are for release candidate testing t/B_Hooks.t ............. ok t/4_MemShare.t .......... ok t/5_MemCopy.t ........... ok Test Summary Report ------------------- t/3_Storable.t (Wstat: 512 Tests: 4 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 23 tests but ran 4. Files=13, Tests=481, 2 wallclock secs ( 0.10 usr 0.02 sys + 1.60 cusr 0.15 csys = 1.87 CPU) Result: FAIL Failed 1/13 test programs. 0/481 subtests failed. make: *** [test_dynamic] Error 255 -> FAIL Installing XML::Simple failed. See /home/libdevel/.cpanm/build.log for details. Expiring 1 work directories. -- Caleb Cushing http://xenoterracide.com
Hi Caleb - thanks for the report. Can you tell me if the test fails consistently for you or whether it was a one-time thing. The fact that the test script complains the file is missing is a bit odd since the test script itself created the file a few lines earlier. That earlier code could potentially fail if (for example) your disk filled up or you were using a network-mounted filesystem and there were transient network issues. Looking at the code I can definitely improve the error checking to have it die at the point of the real failure rather than later on.
Subject: Re: [rt.cpan.org #79117] File does not exist: t/desertnet.xml at t/3_Storable.t line 158.
Date: Tue, 21 Aug 2012 18:30:21 -0500
To: bug-XML-Simple [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
On Tue, Aug 21, 2012 at 5:17 PM, Grant McLean via RT <bug-XML-Simple@rt.cpan.org> wrote: Show quoted text
> Can you tell me if the test fails consistently for you or whether it was > a one-time thing. > > The fact that the test script complains the file is missing is a bit odd > since the test script itself created the file a few lines earlier. That > earlier code could potentially fail if (for example) your disk filled up > or you were using a network-mounted filesystem and there were transient > network issues. Looking at the code I can definitely improve the error > checking to have it die at the point of the real failure rather than > later on.
It failed at least 3 attempts for me. Disk would not be full due to the fact that I continued to install things after. It was on a VPS, no network mounts. I tried it on 2 different perlbrew's 5.16.1 and 5.14.2 and most of the 5.14.2 brew was downloaded and installed after the 5.16.1 try. -- Caleb Cushing http://xenoterracide.com
It seems likely that the original cause of this problem is that XML::Simple's test suite did not work when tests were run in parallel. So the "File does not exist" error was because a different test script had just deleted the file. The latest release of XML::Simple uses a unique filename for each test and seems to run reliably under 'prove -j9'. I've also removed a number of useless eval wrappers from the test suite which would potentially mask the root cause of problems, so if this failure does reoccur we should be able to see why. Thanks again for the report. Grant