Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Module-CoreList CPAN distribution.

Report information
The Basics
Id: 79109
Status: open
Priority: 0/
Queue: Module-CoreList

People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.71
Fixed in: 2.72



Subject: TieHashDelta.pm uses perl 5.14-specific "each" invocation
Module-CoreList 2.71 fails to build with perl < 5.14 due to the use of "each" with a hash reference in TieHashDelta.pm: $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Type of arg 1 to each must be hash or array (not hash element) at /builddir/build/BUILD/Module-CoreList-2.71/blib/lib/Module/CoreList/TieHashDelta.pm line 71, near "};" Compilation failed in require at /builddir/build/BUILD/Module-CoreList-2.71/blib/lib/Module/CoreList.pm line 5. BEGIN failed--compilation aborted at /builddir/build/BUILD/Module-CoreList-2.71/blib/lib/Module/CoreList.pm line 5. Compilation failed in require at t/corelist.t line 3. BEGIN failed--compilation aborted at t/corelist.t line 3. t/corelist.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run The documentation for "each" refers to this usage as being experimental: Starting with Perl 5.14, each can take a scalar EXPR, which must hold reference to an unblessed hash or array. The argument will be dereferenced automatically. This aspect of each is considered highly experimental. The exact behaviour may change in a future version of Perl. ... To avoid confusing would-be users of your code who are running earlier versions of Perl with mysterious syntax errors, put this sort of thing at the top of your file to signal that your code will work only on Perls of a recent vintage: use 5.012; # so keys/values/each work on arrays use 5.014; # so keys/values/each work on scalars (experimental)
On Tue Aug 21 07:47:04 2012, paul@city-fan.org wrote: Show quoted text
> Module-CoreList 2.71 fails to build with perl < 5.14 due to the use of > "each" with a hash reference in TieHashDelta.pm: > > $ make test > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > Type of arg 1 to each must be hash or array (not hash element) at > /builddir/build/BUILD/Module-CoreList- > 2.71/blib/lib/Module/CoreList/TieHashDelta.pm > line 71, near "};" > Compilation failed in require at > /builddir/build/BUILD/Module-CoreList-2.71/blib/lib/Module/CoreList.pm > line 5. > BEGIN failed--compilation aborted at > /builddir/build/BUILD/Module-CoreList-2.71/blib/lib/Module/CoreList.pm > line 5. > Compilation failed in require at t/corelist.t line 3. > BEGIN failed--compilation aborted at t/corelist.t line 3. > t/corelist.t ...... > Dubious, test returned 255 (wstat 65280, 0xff00) > No subtests run
I’ve patched it in the perl repository with commit 711703f98.
From: d.thomas [...] its.uq.edu.au
Show quoted text
> I’ve patched it in the perl repository with commit 711703f98.
confirm it now works with RHEL5 perl-5.8.8
From: paul [...] city-fan.org
On Tue Aug 21 18:25:17 2012, d.thomas@its.uq.edu.au wrote: Show quoted text
> > I’ve patched it in the perl repository with commit 711703f98.
> confirm it now works with RHEL5 perl-5.8.8
Works for me too, even as far back as RHEL4 with perl 5.8.5.
Subject: Re: [rt.cpan.org #79109] TieHashDelta.pm uses perl 5.14-specific "each" invocation
Date: Wed, 22 Aug 2012 10:48:42 +0100
To: "paul [...] city-fan.org via RT" <bug-Module-CoreList [...] rt.cpan.org>
From: "Chris 'BinGOs' Williams" <chris [...] bingosnet.co.uk>
On Wed, Aug 22, 2012 at 03:58:22AM -0400, paul@city-fan.org via RT wrote: Show quoted text
> Queue: Module-CoreList > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=79109 > > > On Tue Aug 21 18:25:17 2012, d.thomas@its.uq.edu.au wrote:
> > > I???ve patched it in the perl repository with commit 711703f98.
> > confirm it now works with RHEL5 perl-5.8.8
> > Works for me too, even as far back as RHEL4 with perl 5.8.5.
I released 2.72 to CPAN last night with the fixes. Many thanks, -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================
Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.