Skip Menu |

This queue is for tickets about the Net-SAML2 CPAN distribution.

Report information
The Basics
Id: 79087
Status: rejected
Priority: 0/
Queue: Net-SAML2

People
Owner: TIMLEGGE [...] cpan.org
Requestors: ROBN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.17
Fixed in: (no value)



Subject: Remove dependency on Dancer
The Net::SAML2 modules themselves don't depend on Dancer, only the test app. That means I end up deploying a lot of stuff I don't need to my web servers, or I have to add a special-case in my build system. Both these are a bit sucky. Can you just remove the dependency?
On Sun Aug 19 04:03:44 2012, ROBN wrote: Show quoted text
> The Net::SAML2 modules themselves don't depend on Dancer, only the test > app. That means I end up deploying a lot of stuff I don't need to my web > servers, or I have to add a special-case in my build system. Both these > are a bit sucky. Can you just remove the dependency?
Dancer (along with WWW::Mechanize etc) are marked test_requires in Makefile.PL - does your build system install these along with the runtime dependencies?
On Mon Aug 27 09:06:03 2012, CHRISA wrote: Show quoted text
> Dancer (along with WWW::Mechanize etc) are marked test_requires in > Makefile.PL - does your > build system install these along with the runtime dependencies?
Yes. cpanm installs these because it believes it needs them to run the tests, which it was test_requires is for (aiui anyway).
From: d.thomas [...] its.uq.edu.au
On Mon Aug 27 09:19:27 2012, ROBN wrote: Show quoted text
> On Mon Aug 27 09:06:03 2012, CHRISA wrote: >
> > Dancer (along with WWW::Mechanize etc) are marked test_requires in > > Makefile.PL - does your > > build system install these along with the runtime dependencies?
> > Yes. cpanm installs these because it believes it needs them to run the > tests, which it was test_requires is for (aiui anyway).
In my automated build system I added the following 'Net::SAML2' => # [DMT 17-Oct-2013] https://rt.cpan.org/Public/Bug/Display.html?id=79087 { 'msg' => "disable testapp which requires dancer", 'disable' => [ 'testapp/Makefile.PL' ], }, and applied this patch diff -u Net-SAML2-0.17.orig/META.yml Net-SAML2-0.17/META.yml --- Net-SAML2-0.17.orig/META.yml 2012-01-14 02:01:14.000000000 +1000 +++ Net-SAML2-0.17/META.yml 2013-01-17 14:48:44.000000000 +1000 @@ -3,7 +3,7 @@ author: - 'Chris Andrews <chrisandrews@venda.com>' build_requires: - Dancer: 1.2000 +# Dancer: 1.2000 ExtUtils::MakeMaker: 6.56 Test::More: 0.88 WWW::Mechanize: 1.66 diff -u Net-SAML2-0.17.orig/Makefile.PL Net-SAML2-0.17/Makefile.PL --- Net-SAML2-0.17.orig/Makefile.PL 2012-01-14 02:00:44.000000000 +1000 +++ Net-SAML2-0.17/Makefile.PL 2013-01-17 14:48:59.000000000 +1000 @@ -39,7 +39,7 @@ author_requires 'Test::Pod::Coverage' => '1.04'; test_requires 'Test::More' => '0.88'; -test_requires 'Dancer' => '1.2000'; +#test_requires 'Dancer' => '1.2000'; test_requires 'WWW::Mechanize' => '1.66'; test_requires 'YAML'; Common subdirectories: Net-SAML2-0.17.orig/inc and Net-SAML2-0.17/inc Common subdirectories: Net-SAML2-0.17.orig/lib and Net-SAML2-0.17/lib Common subdirectories: Net-SAML2-0.17.orig/t and Net-SAML2-0.17/t Common subdirectories: Net-SAML2-0.17.orig/testapp and Net-SAML2-0.17/testapp
Recently took on the maintainer role and I have no plans to change this at this point. Net::SAML2 does not appear to have a high usage but once it is released I do plan to package it for AlpineLinux if that helps at all... Feel free to offer a PR at https://github.com/timlegge/perl-Net-SAML2