Skip Menu |

This queue is for tickets about the Lingua-JP-Kanjidic CPAN distribution.

Report information
The Basics
Id: 79005
Status: new
Priority: 0/
Queue: Lingua-JP-Kanjidic

People
Owner: Nobody in particular
Requestors: NGLENN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.1
Fixed in: (no value)



Subject: need to set recsep on Windows
Tie::File uses "\r\n" as the recsep variable on Windows. The Kanjidic files uses "\n", and that's what is used in the minidic test file. It's a matter of adding ', "\n"' to the tie command. When I tracked this down I also changed your test file, so I'm submitting a patch for the directory.
Subject: Lingua-JP-Kanjidic-1.1.patch
diff -urd Lingua-JP-Kanjidic-1.1/lib/Lingua/JP/Kanjidic.pm Lingua-JP-Kanjidic-1.1new/lib/Lingua/JP/Kanjidic.pm --- Lingua-JP-Kanjidic-1.1/lib/Lingua/JP/Kanjidic.pm 2007-09-23 23:11:14 -0400 +++ Lingua-JP-Kanjidic-1.1new/lib/Lingua/JP/Kanjidic.pm 2012-08-15 21:34:38 -0400 @@ -42,7 +42,7 @@ my ($self, $file) = @_; $file ||= "kanjidic"; my @stuff; - tie @stuff, 'Tie::File', $file or die "Couldn't tie $file: $@"; + tie @stuff, 'Tie::File', $file, "\n" or die "Couldn't tie $file: $@"; bless { pos => 1, cache => {}, diff -urd Lingua-JP-Kanjidic-1.1/t/Lingua-JP-Kanjidic.t Lingua-JP-Kanjidic-1.1new/t/Lingua-JP-Kanjidic.t --- Lingua-JP-Kanjidic-1.1/t/Lingua-JP-Kanjidic.t 2004-08-03 08:14:20 -0400 +++ Lingua-JP-Kanjidic-1.1new/t/Lingua-JP-Kanjidic.t 2012-08-15 21:34:15 -0400 @@ -1,9 +1,9 @@ -use Test::More tests => 5; +use Test::More tests => 6; use_ok("Lingua::JP::Kanjidic"); my $x = new Lingua::JP::Kanjidic ("t/minidic"); isa_ok($x, "Lingua::JP::Kanjidic"); -use Data::Dumper; my $a = $x->next; +isa_ok($a,'Lingua::JP::Kanjidic::Kanji'); is_deeply($a->meaning, [ 'Asia', 'rank next', 'come after', '-ous' ], "Picks up a- OK"); ok($a->joyo, "a- is joyo");