| Subject: | Invalid skip() in t/ip_mreq.t |
When testing Socket 2.003 prior to installation, I got:
t/ip_mreq.t ...... 1/6 skip() was passed a non-numeric number of tests.
Did you get the arguments backwards? at t/ip_mreq.t line 34
# Looks like you planned 6 tests but ran 4.
t/ip_mreq.t ...... Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/6 subtests
(less 1 skipped subtest: 3 okay)
The attached patch (developed against 2.003) takes care of the problem.
$ uname -a
Darwin name-withheld 9.8.0 Darwin Kernel Version 9.8.0: Wed Jul 15
16:55:01 PDT 2009; root:xnu-1228.15.4~1/RELEASE_I386 i386
$ perl -v
This is perl 5, version 16, subversion 1 (v5.16.1) built for darwin-2level
Copyright 1987-2012, Larry Wall
| Subject: | Socket-ip_mreq.patch |
--- t/ip_mreq.old 2012-08-15 09:11:47.000000000 -0400
+++ t/ip_mreq.t 2012-08-15 15:49:07.000000000 -0400
@@ -31,7 +31,7 @@
SKIP: {
my $mreq;
- skip 3, "No pack_ip_mreq_source" unless defined eval { $mreq = pack_ip_mreq_source "\xe0\0\0\2", "\x0a\0\0\1", INADDR_ANY };
+ skip "No pack_ip_mreq_source", 3 unless defined eval { $mreq = pack_ip_mreq_source "\xe0\0\0\2", "\x0a\0\0\1", INADDR_ANY };
@unpacked = unpack_ip_mreq_source $mreq;