Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Mojolicious-Plugin-DomIdHelper CPAN distribution.

Report information
The Basics
Id: 78970
Status: open
Priority: 0/
Queue: Mojolicious-Plugin-DomIdHelper

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.04
Fixed in: (no value)



Subject: Makefile.PL fails if perldoc not in the path
As per subject. In the Makefile.PL the location of $^X is the location of perl. One could append "doc" to get at the location of perldoc. Just a suggestion... BTW, it is fragile to have decreasing version numbers. Since the version number 0.1 has been used in the past and 0.04 is lower than 0.1 it can be confusing for tools and humans when the newest release has verion number 0.04. Thanks,
On Wed Aug 15 00:22:32 2012, ANDK wrote: Show quoted text
> ... $^X is the location of perl. One could append "doc" to get > at the location of perldoc. Just a suggestion...
On Win32 $^X is perl.exe. Maybe $Config{bin} + perldoc instead. Hummm... Do you know if it's possible to add a make target that doesn't get added as a module prerequisite? Show quoted text
> BTW, it is fragile to have decreasing version numbers. Since the version > number 0.1 has been used in the past and 0.04 is lower than 0.1
Yes, I was hoping I could make that change without anyone noticing :\ Did you have 0.1 installed? Thanks for the info. -Skye
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #78970] Makefile.PL fails if perldoc not in the path
Date: Thu, 16 Aug 2012 21:21:18 +0200
To: bug-Mojolicious-Plugin-DomIdHelper [...] rt.cpan.org
From: andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Thu, 16 Aug 2012 03:08:09 -0400, "sshaw via RT" <bug-Mojolicious-Plugin-DomIdHelper@rt.cpan.org> said:
Show quoted text
> On Win32 $^X is perl.exe. Maybe $Config{bin} + perldoc instead.
Good point! Show quoted text
> Hummm... Do you know if it's possible to add a make target that doesn't get added as a > module prerequisite?
Sure, I'm always doing it with a postample hook, in a nutshell, this looks like: sub postamble { return " .SUFFIXES: .rnc .rng .rnc.rng: trang -I rnc -O rng $*.rnc $*.rng update: dd-prefs " } That is, you can return arbitrary text that ends up in the Makefile from a postamble subroutine. Show quoted text
>> BTW, it is fragile to have decreasing version numbers. Since the version >> number 0.1 has been used in the past and 0.04 is lower than 0.1
Show quoted text
> Yes, I was hoping I could make that change without anyone noticing :\ Did you have 0.1 > installed?
No, one tool that doesn't forget historic version numbers is RT, it has a pull-down offering all version numbers of any distribution; another tool is the matrix: it disaplys the results of 0.1 when I ask for http://matrix.cpantesters.org/?dist=Mojolicious-Plugin-DomIdHelper; metacpan, on the other hand, seems to be too clever: although it usually has even deleted versions in the pull down, it has the 0.1 missing completely when you visit https://metacpan.org/release/Mojolicious-Plugin-DomIdHelper, so that the user who has seen 0.1 elsewhere starts wondering whether maybe 0.1 has just now been released and one should check it out before sending off the bugreport. -- andreas
On Thu Aug 16 15:21:35 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote: Show quoted text
>> On Thu, 16 Aug 2012 03:08:09 -0400, "sshaw via RT" <bug- >> Hummm... Do you know if it's possible to add a make target that >> doesn't get added as a module prerequisite?
> > Sure, I'm always doing it with a postample hook, in a nutshell, this > looks like: > > sub postamble { > ...
That's what I do: https://github.com/sshaw/Mojolicious-Plugin-DomIdHelper/blob/master/ Makefile.PL#L14 But postable() becomes a perquisite of the pm_to_blib target. As opposed to my own personal target that I can run at will. But that's OK (and makes sense)... Show quoted text
> No, one tool that doesn't forget historic version numbers is RT
Hopefully META_MERGE bugtracker will hide some of this from the world :) -Skye
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #78970] Makefile.PL fails if perldoc not in the path
Date: Fri, 17 Aug 2012 07:08:37 +0200
To: bug-Mojolicious-Plugin-DomIdHelper [...] rt.cpan.org
From: andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)
Show quoted text
>>>>> On Thu, 16 Aug 2012 20:29:36 -0400, "sshaw via RT" <bug-Mojolicious-Plugin-DomIdHelper@rt.cpan.org> said:
Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=78970 > > On Thu Aug 16 15:21:35 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de > wrote:
>>> On Thu, 16 Aug 2012 03:08:09 -0400, "sshaw via RT" <bug- >>> Hummm... Do you know if it's possible to add a make target that >>> doesn't get added as a module prerequisite?
>> >> Sure, I'm always doing it with a postample hook, in a nutshell, this >> looks like: >> >> sub postamble { >> ...
Show quoted text
> That's what I do:
Show quoted text
Show quoted text
> But postable() becomes a perquisite of the pm_to_blib target. As > opposed to my own personal target that I can run at will. But that's OK > (and makes sense)...
But "README.pod" does not become a dependent target by writing the postamble but by simply distributing the file. Witness: Mojolicious-Plugin-DomIdHelper-0.04-jG7JmY% perl Makefile.PL Warning: prerequisite Mojolicious 2.20 not found. Writing Makefile for Mojolicious::Plugin::DomIdHelper Writing MYMETA.yml Mojolicious-Plugin-DomIdHelper-0.04-jG7JmY% make -n | grep perldoc perldoc -uT lib/Mojolicious/Plugin/DomIdHelper.pm > README.pod Mojolicious-Plugin-DomIdHelper-0.04-jG7JmY% rm README.pod Mojolicious-Plugin-DomIdHelper-0.04-jG7JmY% perl Makefile.PL Warning: prerequisite Mojolicious 2.20 not found. Writing Makefile for Mojolicious::Plugin::DomIdHelper Writing MYMETA.yml Mojolicious-Plugin-DomIdHelper-0.04-jG7JmY% make -n | grep perldoc <no output> -- andreas
On Fri Aug 17 01:08:55 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote: Show quoted text
>> On Thu, 16 Aug 2012 20:29:36 -0400, "sshaw via RT" <bug-
>
>> But postable() becomes a perquisite of the pm_to_blib target. As >> opposed to my own personal target that I can run at will.
> > But "README.pod" does not become a dependent target by writing the > postamble but by simply distributing the file.
Eureka! Nevertheless, due to the fact that I will -at some point I'm sure- forget to manually generate the README.pod, I've opted for the $Config solution: https://github.com/sshaw/Mojolicious-Plugin- DomIdHelper/commit/b336794b4da3bbde9efd3cf814618ccf350f586c Ticket wil be closed upon the next release. Thanks, Skye