Bug #78926 for libnet: Timeout should be set when creating data connection

Sun Aug 12 23:49:48 2012 oleg [...] cpan.org - Ticket created

Subject:

Timeout should be set when creating data connection

Currently connection time inside sub _dataconn not limited. So, with broken/slow servers program may hang for long time. My propose is to inherit connect timeout value from command connection.

Thu Jan 30 08:45:25 2014 shay [...] cpan.org - Correspondence added

The timeout value is set in sub _dataconn() in the current version of libnet (1.24), around line 956: if ($data) { ${*$data} = ""; $data->timeout($ftp->timeout);

Thu Jan 30 08:45:26 2014 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 30 08:45:26 2014 shay [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jan 30 08:45:27 2014 shay [...] cpan.org - Fixed in 1.24 added

Thu Jan 30 10:17:45 2014 oleg [...] cpan.org - Correspondence added

Чтв Янв 30 08:45:25 2014, SHAY писал: Show quoted text

> The timeout value is set in sub _dataconn() in the current version of > libnet (1.24), around line 956: > > if ($data) { > ${*$data} = ""; > $data->timeout($ftp->timeout);

I think this is not totally correct. On line 956 we sets timeout only after successfull connection. But connection time not limited in the current implementation. So we should set timeout when performing connection. I sent pull request on github to your fork of libnet some time ago: https://github.com/steve-m-hay/perl-libnet/pull/1

Thu Jan 30 10:21:15 2014 oleg [...] cpan.org - Status changed from 'resolved' to 'open'

Thu Jan 30 13:02:55 2014 shay [...] cpan.org - Correspondence added

On Thu Jan 30 10:17:45 2014, OLEG wrote: Show quoted text

> Чтв Янв 30 08:45:25 2014, SHAY писал:

> > The timeout value is set in sub _dataconn() in the current version of > > libnet (1.24), around line 956: > > > > if ($data) { > > ${*$data} = ""; > > $data->timeout($ftp->timeout);

> > > I think this is not totally correct. On line 956 we sets timeout only > after successfull connection. But connection time not limited in the > current implementation. So we should set timeout when performing > connection. I sent pull request on github to your fork of libnet some > time ago: https://github.com/steve-m-hay/perl-libnet/pull/1

Ah, yes. Sorry, I see it now. I've merged your pull request in, so this patch will be in 1.25 soon. Many thanks!

Thu Jan 30 13:02:56 2014 shay [...] cpan.org - Status changed from 'open' to 'patched'

Thu Jan 30 13:02:56 2014 shay [...] cpan.org - Fixed in 1.24 deleted

Tue Feb 04 13:41:21 2014 shay [...] cpan.org - Correspondence added

Thanks again, now fixed in libnet-1.25.

Tue Feb 04 13:41:21 2014 shay [...] cpan.org - Status changed from 'patched' to 'resolved'

Tue Feb 04 13:41:22 2014 shay [...] cpan.org - Fixed in 1.25 added