Skip Menu |

This queue is for tickets about the Tk CPAN distribution.

Report information
The Basics
Id: 78824
Status: resolved
Priority: 0/
Queue: Tk
People
Owner: Nobody in particular
Requestors: 'spro^^*%*^6ut# [...] &$%*c
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 804.031

History Show all quoted text
  Mon Aug 06 17:42:13 2012 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Ticket created
Subject: Fix compilation under threaded bleadperl
CopSTASHPV is no longer an lvalue under threads. (It never was under non-threaded builds.) See attachment.
Subject: open_fKRBhHDm.txt
diff -rup Tk-804.030-s6AXtr-orig/tkGlue.c Tk-804.030-s6AXtr/tkGlue.c --- Tk-804.030-s6AXtr-orig/tkGlue.c 2010-05-29 02:58:04.000000000 -0700 +++ Tk-804.030-s6AXtr/tkGlue.c 2012-08-06 14:40:56.000000000 -0700 @@ -4194,11 +4194,7 @@ int type; SV *x = NULL; int prefix = '?'; name = SvPV(sv,na); -#ifdef USE_ITHREADS - CopSTASHPV(PL_curcop) = NULL; -#else - CopSTASH(PL_curcop) = NULL; -#endif + CopSTASH_set(PL_curcop, NULL); switch (type) { case TK_CONFIG_SCALARVAR:
  Fri May 17 16:34:36 2013 SREZIC [...] cpan.org - Correspondence added
On 2012-08-06 17:42:13, SPROUT wrote: Show quoted text
> CopSTASHPV is no longer an lvalue under threads. (It never was under > non-threaded builds.) > > See attachment.
Applied in commit 8eb3ec51a58dd02334118d8f0aa1bebb5704d15c.
  Fri May 17 16:34:36 2013 The RT System itself - Status changed from 'new' to 'open'
  Fri May 17 16:34:37 2013 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'
  Sat May 18 04:58:44 2013 CHORNY [...] cpan.org - Correspondence added
Same error in tkGlue.c: tkGlue.c: In function 'LangSaveVar': tkGlue.c:4161:26: error: lvalue required as left operand of assignment -- Alexandr Ciornii, http://chorny.net
  Sat May 18 05:37:11 2013 CHORNY [...] cpan.org - Correspondence added
On Sat May 18 04:58:44 2013, CHORNY wrote: Show quoted text
> Same error in tkGlue.c:
copstashset.c was not included into distribution. When I included it from repository, Tk compiled correctly and all tests passed. -- Alexandr Ciornii, http://chorny.net
  Sat May 18 05:37:12 2013 CHORNY [...] cpan.org - Status changed from 'patched' to 'open'
  Mon May 20 12:00:30 2013 SREZIC [...] cpan.org - Correspondence added
On 2013-05-18 05:37:11, CHORNY wrote: Show quoted text
> On Sat May 18 04:58:44 2013, CHORNY wrote:
> > Same error in tkGlue.c:
> > copstashset.c was not included into distribution. When I included it > from repository, Tk compiled correctly and all tests passed. >
Argh! Fixed in commit 023c3765994588f65f2db018fa8227196a13ccb9. Will be hopefully in the next dev release. Regards, Slaven
  Mon May 20 12:00:31 2013 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'
  Sun May 26 05:06:18 2013 SREZIC [...] cpan.org - Status changed from 'patched' to 'resolved'
  Sun May 26 05:06:19 2013 SREZIC [...] cpan.org - Fixed in 804.031 added