Skip Menu |

This queue is for tickets about the XML-RPC CPAN distribution.

Report information
The Basics
Id: 78807
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: XML-RPC

People
Owner: Nobody in particular
Requestors: cavac [...] cavac.at
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.9
Fixed in: 1



Subject: No custom UA string
Allow custom UserAgent-Strings. This is important if multiple, different clients are accessing (or multiple versions of the same client). With this patch, you can call it something like this: my $xmlrpc = XML::RPC->new($apiURL, ("User-Agent" => "Scarecrow/$VERSION"));
Subject: rpc.patch
--- RPC.pm_old 2012-08-06 11:48:16.000000000 +0200 +++ RPC.pm 2012-08-06 11:56:45.000000000 +0200 @@ -138,7 +138,7 @@ sub call { $xml_out, { 'Content-Type' => 'text/xml', - 'User-Agent' => 'XML-RPC/' . $VERSION, + 'User-Agent' => defined($self->{tpp}->{'User-Agent'}) ? $self->{tpp}->{'User-Agent'} : 'XML-RPC/' . $VERSION, 'Content-Length' => length($xml_out) } );
I agree with the patch proposal, but shouldn't the option name be 'user_agent' to correctly match the option name in XML::TreePP? https://metacpan.org/module/XML::TreePP#user_agent
Merged changes from XML::RPC::CustomUA (and deprecated the CustomUA module at the same time)