Skip Menu |

This queue is for tickets about the Net-Google-Analytics CPAN distribution.

Report information
The Basics
Id: 78789
Status: resolved
Priority: 0/
Queue: Net-Google-Analytics

People
Owner: Nobody in particular
Requestors: JJSCHUTZ [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.00
Fixed in: (no value)



Subject: retrieve_paged infinite loop
retrieve_paged can get into an infinite loop if the response is valid but has 0 results (an easy condition to create by setting the filter to a value that never occurs). In this case totalResults is 0 but itemsPerPage is non-zero so the loop never terminates. Also, there is no checking of $page->is_success, so a failure (such as a Forbidden response due to the specified GA profile ID not being available to the authorised user) causes a hard-to-interpret error later in the code. Regards, Jon Schutz http://notes.jschutz.net/
Thanks for your report. I hope I fixed all the issues you mentioned with my latest commits: https://github.com/nwellnhof/Net-Google-Analytics/commits/master I'm going to release version 3.01 with these fixes in the next days.
Fixed in version 3.01.