Skip Menu |

This queue is for tickets about the DhMakePerl CPAN distribution.

Report information
The Basics
Id: 78751
Status: open
Priority: 0/
Queue: DhMakePerl
People
Owner: Nobody in particular
Requestors: DKOGAN [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Aug 02 19:21:00 2012 DKOGAN [...] cpan.org - Ticket created
Subject: Debian::Control barfs on comments
Debian::Control currently doesn't support # comment characters. This can be simply enabled by telling the parser itself to do this. In Debian::Control::read(), the following makes it work (only the 'stripComments' option is new): my $stanzas = $self->_parser->$parser_method( $file, { useTieIxHash => 1, verbMultiLine => 1, stripComments => 1 } ); Note that the parser doesn't handle this quite correctly either, but I'll report that as a separate bug to the Parse::DebControl people.
  Fri Aug 03 03:02:05 2012 jeremiah [...] cpan.org - Correspondence added
On Thu Aug 02 19:21:00 2012, DKOGAN wrote: Show quoted text
> Debian::Control currently doesn't support # comment characters. This can > be simply enabled by telling the parser itself to do this. In > Debian::Control::read(), the following makes it work (only the > 'stripComments' option is new): > > my $stanzas = $self->_parser->$parser_method( $file, > { useTieIxHash => 1, verbMultiLine => 1, stripComments => 1 } ); > > Note that the parser doesn't handle this quite correctly either, but I'll > report that as a separate bug to the Parse::DebControl people.
I suspect this might be a "won't fix" because teh debian/control file is not really supposed to have comments. Comments go in the changelog or other more appropriate places, no one will think to look for them in a control file.
  Fri Aug 03 03:02:06 2012 The RT System itself - Status changed from 'new' to 'open'
  Fri Aug 03 03:34:29 2012 dima [...] secretsauce.net - Correspondence added
Subject: Re: [rt.cpan.org #78751] Debian::Control barfs on comments
Date: Fri, 3 Aug 2012 00:34:13 -0700
To: bug-DhMakePerl [...] rt.cpan.org
From: Dima Kogan <dima [...] secretsauce.net>
Show quoted text
> I suspect this might be a "won't fix" because teh debian/control file > is not really supposed to have comments. Comments go in the changelog > or other more appropriate places, no one will think to look for them > in a control file.
I don't think so. Look at the second-to-last paragraph of Section 5.1 of the Debian policy: http://www.debian.org/doc/debian-policy/ch-controlfields.html It explicitly allows comments. Furthermore, there were already two bugs reported against libparse-debcontrol-perl that were directly related to its comment parsing being broken (not missing, but broken). I submitted a patch that fixes the failure I was seeing, and likely both of these bugs too: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640063
  Fri Aug 03 04:03:15 2012 jeremiah [...] cpan.org - Correspondence added
On Fri Aug 03 03:34:29 2012, dima@secretsauce.net wrote: Show quoted text
> > I suspect this might be a "won't fix" because teh debian/control
> file
> > is not really supposed to have comments. Comments go in the
> changelog
> > or other more appropriate places, no one will think to look for them > > in a control file.
> > I don't think so. Look at the second-to-last paragraph of Section 5.1 > of the > Debian policy: > > http://www.debian.org/doc/debian-policy/ch-controlfields.html > > It explicitly allows comments. Furthermore, there were already two > bugs reported > against libparse-debcontrol-perl that were directly related to its > comment > parsing being broken (not missing, but broken). I submitted a patch > that fixes > the failure I was seeing, and likely both of these bugs too: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640063
Ah, my apologies. I should have read the Debian policy before commenting.