Skip Menu |

This queue is for tickets about the Pod-Spell-CommonMistakes CPAN distribution.

Report information
The Basics
Id: 78641
Status: stalled
Priority: 0/
Queue: Pod-Spell-CommonMistakes
People
Owner: Nobody in particular
Requestors: dmacks [...] netspace.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Jul 29 07:02:09 2012 dmacks [...] netspace.org - Ticket created
Subject: Un-necessary test for Module::Build
Date: Sun, 29 Jul 2012 07:01:50 -0400
To: bug-Pod-Spell-CommonMistakes [...] rt.cpan.org
From: "Daniel Macks" <dmacks [...] netspace.org>
Pod-Spell-CommonMistakes-1.000 t/000-report-versions-tiny.t has a check for: # Module::Build                                 => 0.4001     (want 0.3601) but why? M::B doesn't appear to be used anywhere by this module at runtime or for self-testing. Its only use might be at build-time, when Build.PL is used. But by the time the module is at the self-testing stage, M::B has already been tested and Build.PL would crash if this versioning is not met thanks to that file asserting: use Module::Build 0.3601; And this package includes a Makefile.PL that appears to be an independent build-system that does not use Build.PL or M::B at all (so it need not have any minimum version, or even exist at all). dan -- Daniel Macks dmacks@netspace.org
  Fri Oct 31 17:15:52 2014 APOCAL [...] cpan.org - Correspondence added
Hello, Thanks for pointing this out, however I think it's not something I am capable of changing. Let me explain :) 1. That test is auto-generated by Dist::Zilla::Plugin::ReportVersions::Tiny and as such it checks all the prerequisites loaded as reported from the toolchain stuff ( META.yml, Makefile.PL, whatever ) 2. I'm not a toolchain expert but I assume that the version check is pretty normal, to make sure that your installed versions are new enough to handle the installation. 3. The toolchain has evolved quite a lot, and I've been behind the times. Maybe the newest release (v1.001 on CPAN) fixed this? Maybe not? Please let me know! On Sun Jul 29 07:02:09 2012, dmacks@netspace.org wrote: Show quoted text
> Pod-Spell-CommonMistakes-1.000 t/000-report-versions-tiny.t has a > check for: > > # Module::Build                                 => 0.4001     (want > 0.3601) > > but why? M::B doesn't appear to be used anywhere by this module at > runtime or for self-testing. Its only use might be at build-time, when > Build.PL is used. But by the time the module is at the self-testing > stage, M::B has already been tested and Build.PL would crash if this > versioning is not met thanks to that file asserting: > > use Module::Build 0.3601; > > And this package includes a Makefile.PL that appears to be an > independent build-system that does not use Build.PL or M::B at all (so > it need not have any minimum version, or even exist at all). > > dan > > -- > Daniel Macks > dmacks@netspace.org
-- ~Apocalypse
  Fri Oct 31 17:15:53 2014 The RT System itself - Status changed from 'new' to 'open'
  Fri Oct 31 17:15:53 2014 APOCAL [...] cpan.org - Status changed from 'open' to 'stalled'