Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-TCP CPAN distribution.

Report information
The Basics
Id: 78615
Status: resolved
Priority: 0/
Queue: Test-TCP

People
Owner: Nobody in particular
Requestors: MITHALDU [...] cpan.org
Cc: mst [...] shadowcat.co.uk
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: mst [...] shadowcat.co.uk
Subject: fix port checking on Win32 by performing it in another process [with patch]
Test::TCP is currently randomly failing randomly on Win32 and i believe i was able to pinpoint the reason and fix it. The fix is in this pull request: https://github.com/tokuhirom/test-tcp/pull/4 Some background info: I believe this to be a race condition since i was only able to consistently reproduce the error on slow machines. Since implementing it i've tested the branch numerous times on slow and fast windows machines as well as on linux and it passed fine everywhere. If you have any questions or change requests on the pull request, please don't hesitate to ask, i'll happily oblige. :)
Since you asked me to make the changes smaller in scope, i looked it over and could reduce it a lot, hope this will be easier to accept. :) https://github.com/tokuhirom/test-tcp/pull/5
Pull-req was merged. On 2012-7月-28 土 01:06:54, MITHALDU wrote: Show quoted text
> Since you asked me to make the changes smaller in scope, i looked it over > and could reduce it a lot, hope this will be easier to accept. :) > > https://github.com/tokuhirom/test-tcp/pull/5