Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the MooseX-Types-Perl CPAN distribution.

Report information
The Basics
Id: 78560
Status: resolved
Priority: 0/
Queue: MooseX-Types-Perl

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: doc update regarding Identifier type
Request application of this patch (the repository is not on github, so no direct pull request is possible): diff --git a/lib/MooseX/Types/Perl.pm b/lib/MooseX/Types/Perl.pm index 23f80bd..e26bd14 100644 --- a/lib/MooseX/Types/Perl.pm +++ b/lib/MooseX/Types/Perl.pm @@ -89,7 +89,9 @@ subtype DistName, =head2 Identifier -An Identifier is something that could be used as a variable name. Generally, +An L<Identifier/"Variable-names"> is something that could be used as a +variable name or other identifier (filehandle, directory handle, subroutine +name, format name, or label). Generally, it's a bunch of alphanumeric characters not starting with a digit. Although Perl identifiers may contain non-ASCII characters in some It wasn't immediately obvious to me that sub names follow the same rules as variable names, and this documentation did not include them explicitly in the Identifier type.
On 2012-07-25 01:36:51, ETHER wrote: Show quoted text
> It wasn't immediately obvious to me that sub names follow the same rules as > variable names, and this documentation did not include them explicitly > in the Identifier type.
I will consider this, but subroutines are just variables, so there isn't really a need to include them. That said, less confusion is better. -- rjbs