Bug #78505 for Crypt-SaltedHash: Noisy tests (Unescaped left brace in regex is deprecated)

Sat Jul 21 12:27:51 2012 wyant [...] cpan.org - Ticket created

Subject:

Noisy tests (Unescaped left brace in regex is deprecated)

Perl 5.17 deprecates unescaped literal left braces in regular expressions, issuing a warning when they are found. The attached patch suppresses this warning. I have called this unimportant because it is only a warning, and in a development release at that.

Sat Jul 21 12:29:11 2012 wyant [...] cpan.org - Correspondence added

Except I forgot to attach the patch. Here it is.

Subject:

Crypt-SaltedHash.patch

--- lib/Crypt/SaltedHash.old 2010-02-27 16:53:23.000000000 -0500 +++ lib/Crypt/SaltedHash.pm 2012-07-21 12:25:42.000000000 -0400 @@ -235,7 +235,7 @@ sub salt_bin { my $self = shift; - return $self->{salt} =~ m!^HEX{(.*)}$!i ? pack( "H*", $1 ) : $self->{salt}; + return $self->{salt} =~ m!^HEX\{(.*)\}$!i ? pack( "H*", $1 ) : $self->{salt}; } =item B<salt_hex()> @@ -247,7 +247,7 @@ sub salt_hex { my $self = shift; - return $self->{salt} =~ m!^HEX{(.*)}$!i + return $self->{salt} =~ m!^HEX\{(.*)\}$!i ? $self->{salt} : 'HEX{' . join( '', unpack( 'H*', $self->{salt} ) ) . '}'; }

Sat Jul 21 12:29:12 2012 wyant [...] cpan.org - Status changed from 'new' to 'open'

Mon Jul 29 14:56:37 2013 ether [...] cpan.org - Severity Unimportant changed to Normal

Wed Jul 31 10:19:35 2013 gshank [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jul 31 10:19:35 2013 gshank [...] cpan.org - Fixed in 0.09 added