Bug #78377 for Catalyst-Runtime: IIS7 + keepalives causes breakage with 3xx and non-empty response bodies

Ok I am done. I decided to make two versions. IISKeepAliveFix.pm - The IIS keep alive fix which effectively on 30[123] response it removes Content-Length, Content-Type headers and sets the body content to undefined. and IISFix.pm - Includes both the fixed up version of IIS6ScriptNameFix and my IISKeepAliveFix in 1. Personally I think IISFix is the way to go but chose whichever you think is best.

package Plack::Middleware::IISKeepAliveFix; use strict; use parent 'Plack::Middleware'; use Plack::Util; sub call { my($self, $env) = @_; if ($env->{SERVER_SOFTWARE} && $env->{SERVER_SOFTWARE} =~ /IIS\/[6-9]\.[0-9]/) { # Fixes wrong SCRIPT_NAME and PATH_INFO that IIS sets my ($path) = ( $env->{REQUEST_URI} =~ /^([^?]*)(?:\?.*)?$/s ); $path =~ s/#.*$// if defined && length; # dumb clients sending URI fragments my @script_name = split(m!/!, URI::Escape::uri_unescape($path)); my @path_translated = split(m!/|\\\\?!, $env->{PATH_TRANSLATED}); my @path_info; while ($script_name[$#script_name] eq $path_translated[$#path_translated]) { pop(@path_translated); unshift(@path_info, pop(@script_name)); } unshift(@path_info, '', ''); $env->{PATH_INFO} = join('/', @path_info); $env->{SCRIPT_NAME} = join('/', @script_name); # Fixes buffer being cut off on redirect when keep-alive is active my $res = $self->app->($env); Plack::Util::response_cb($res, sub { my $res = shift; if ($res->[0] =~ m!^30[123]$! ) { Plack::Util::header_remove($res->[1], 'Content-Length'); Plack::Util::header_remove($res->[1], 'Content-Type'); $res->[2]=undef; } return; }); } } 1; __END__ =head1 NAME Plack::Middleware::IISKeepAliveFix - fixes buffer being cut off on redirect when keep-alive is active on IIS. =head1 SYNOPSIS # in your app.psgi use Plack::Builder; builder { enable "IISKeepAliveFix"; $app; }; # Or from the command line plackup -s FCGI -e 'enable "IISKeepAliveFix"' /path/to/app.psgi =head1 DESCRIPTION This middleware fixes buffer being cut off on redirect when keep-alive is active on IIS. =head1 AUTHORS Florian Ragwitz =cut

package Plack::Middleware::IISFix; use strict; use parent 'Plack::Middleware'; use Plack::Util; sub call { my($self, $env) = @_; if ($env->{SERVER_SOFTWARE} && $env->{SERVER_SOFTWARE} =~ /IIS\/[6-9]\.[0-9]/) { # Fixes wrong SCRIPT_NAME and PATH_INFO that IIS sets my ($path) = ( $env->{REQUEST_URI} =~ /^([^?]*)(?:\?.*)?$/s ); $path =~ s/#.*$// if defined && length; # dumb clients sending URI fragments my @script_name = split(m!/!, URI::Escape::uri_unescape($path)); my @path_translated = split(m!/|\\\\?!, $env->{PATH_TRANSLATED}); my @path_info; while ($script_name[$#script_name] eq $path_translated[$#path_translated]) { pop(@path_translated); unshift(@path_info, pop(@script_name)); } unshift(@path_info, '', ''); $env->{PATH_INFO} = join('/', @path_info); $env->{SCRIPT_NAME} = join('/', @script_name); # Fixes buffer being cut off on redirect when keep-alive is active my $res = $self->app->($env); Plack::Util::response_cb($res, sub { my $res = shift; if ($res->[0] =~ m!^30[123]$! ) { Plack::Util::header_remove($res->[1], 'Content-Length'); Plack::Util::header_remove($res->[1], 'Content-Type'); $res->[2]=undef; } return; }); } } 1; __END__ =head1 NAME Plack::Middleware::IISFix - fixes wrong SCRIPT_NAME and PATH_INFO that IIS sets and fixes buffer being cut off on redirect when keep-alive is active. =head1 SYNOPSIS # in your app.psgi use Plack::Builder; builder { enable "IISFix"; $app; }; # Or from the command line plackup -s FCGI -e 'enable "IISFix"' /path/to/app.psgi =head1 DESCRIPTION This middleware fixes wrong C<SCRIPT_NAME> and C<PATH_INFO> set by IIS and fixes buffer being cut off on redirect when keep-alive is active. =head1 AUTHORS Florian Ragwitz =cut

Ok I finished with the test case, to make the test case work I had to make a few adjustments so I am including the final versions of everything attached here. iis_keep_alive_fix.t - test case IISKeepAliveFix.pm - middleware declare.txt - declaration

use Plack::Middleware::IISKeepAliveFix; $psgi_app = Plack::Middleware::Conditional->wrap( $psgi_app, builder => sub { Plack::Middleware::IISKeepAliveFix->wrap($_[0]) }, condition => sub { my ($env) = @_; return unless $env->{SERVER_SOFTWARE} && $env->{SERVER_SOFTWARE} =~ m!IIS\/[6-9]\.[0-9]!; 1; }, );

package Plack::Middleware::IISKeepAliveFix; use strict; use parent 'Plack::Middleware'; use Plack::Util; sub call { my($self, $env) = @_; # Fixes buffer being cut off on redirect when keep-alive is active my $res = $self->app->($env); Plack::Util::response_cb($res, sub { my $res = shift; if ($res->[0] =~ m!^30[123]$! ) { Plack::Util::header_remove($res->[1], 'Content-Length'); Plack::Util::header_remove($res->[1], 'Content-Type'); $res->[2]=['']; } return; }); } 1; __END__ =head1 NAME Plack::Middleware::IISKeepAliveFix - fixes buffer being cut off on redirect when keep-alive is active on IIS. =head1 SYNOPSIS # in your app.psgi use Plack::Builder; builder { enable "IISKeepAliveFix"; $app; }; # Or from the command line plackup -s FCGI -e 'enable "IISKeepAliveFix"' /path/to/app.psgi =head1 DESCRIPTION This middleware fixes buffer being cut off on redirect when keep-alive is active on IIS. =head1 AUTHORS Florian Ragwitz =cut

use strict; use Test::More; use Plack::Test; use HTTP::Request::Common; use Plack::Middleware::IISKeepAliveFix; my $app=Plack::Middleware::IISKeepAliveFix->wrap( sub { my $env = shift; my $location='/go/?'.join('|', (0..1000)); return [ 302, [ 'Content-Type' => 'text/html', 'Content-Length' => 285, 'Location' => $location, ],[qq~<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <title>Moved</title> </head> <body> <p>This item has moved <a href="$location">here</a>.</p> </body> </html>~] ]; }); test_psgi $app => sub { my $cb = shift; my $res = $cb->(GET "/"); ok(!$res->content); ok(!$res->content_length); ok(!$res->content_type); }; done_testing;

I found a solution faster then I though, attaching all the stuff.

use Plack::Middleware::IISKeepAliveFix; $psgi_app = Plack::Middleware::Conditional->wrap( $psgi_app, builder => sub { Plack::Middleware::IISKeepAliveFix->wrap($_[0]) }, condition => sub { my ($env) = @_; return unless $env->{SERVER_SOFTWARE} && $env->{SERVER_SOFTWARE} =~ m!IIS\/7\.[0-9]!; 1; }, );

package Plack::Middleware::IISKeepAliveFix; use strict; use parent 'Plack::Middleware'; use Plack::Util; sub call { my($self, $env) = @_; # Fixes buffer being cut off on redirect when keep-alive is active my $res = $self->app->($env); Plack::Util::response_cb($res, sub { my $res = shift; if ($res->[0] =~ m!^30[123]$! ) { Plack::Util::header_remove($res->[1], 'Content-Length'); Plack::Util::header_remove($res->[1], 'Content-Type'); return sub{ my $chunk; return unless defined $chunk; return ''; }; } return; }); } 1; __END__ =head1 NAME Plack::Middleware::IISKeepAliveFix - fixes buffer being cut off on redirect when keep-alive is active on IIS. =head1 SYNOPSIS # in your app.psgi use Plack::Builder; builder { enable "IISKeepAliveFix"; $app; }; # Or from the command line plackup -s FCGI -e 'enable "IISKeepAliveFix"' /path/to/app.psgi =head1 DESCRIPTION This middleware fixes buffer being cut off on redirect when keep-alive is active on IIS. =head1 AUTHORS Florian Ragwitz =cut

use strict; use Test::More; use Plack::Test; use HTTP::Request::Common; use Plack::Middleware::IISKeepAliveFix; my $app=Plack::Middleware::IISKeepAliveFix->wrap( sub { my $env = shift; my $location='/go/?'.join('|', (0..1000)); return [ 302, [ 'Content-Type' => 'text/html', 'Content-Length' => 285, 'Location' => $location, ],[qq~<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <title>Moved</title> </head> <body> <p>This item has moved <a href="$location">here</a>.</p> </body> </html>~] ]; }); test_psgi(app=>$app,client=> sub { my $cb = shift; my $res = $cb->(GET "/"); ok(!$res->content); ok(!$res->content_length); ok(!$res->content_type); }); done_testing;