Bug #78218 for Net-OpenID-Common: Yahoo HTML parsing error

Thu Jul 05 09:55:07 2012 kevinbosak [...] gmail.com - Ticket created

Subject:

Yahoo HTML parsing error

I have a Dancer application using Perl 5.14.2 and Net::OpenID::Consumer. While the other OpenID providers our site supports work fine, authenticating via Yahoo causes HTML::Parser to thow this error: "Parsing of undecoded UTF-8 will give garbage when decoding entities". This happens after the user logs into Yahoo and is sent back to our site with a token. More info, a code sample, and a possible fix here: http://stackoverflow.com/questions/11192557/how-can-i-avoid-encoding-errors-using- netopenidconsumer-with-yahoo-openids

Mon Aug 06 13:18:50 2012 VLYON [...] cpan.org - Correspondence added

Here's a git diff to apply that'll fix this bug. I don't have access to commit to: https://github.com/wrog/Net-OpenID- Common diff --git a/lib/Net/OpenID/URIFetch.pm b/lib/Net/OpenID/URIFetch.pm index 909c30a..41d7110 100644 --- a/lib/Net/OpenID/URIFetch.pm +++ b/lib/Net/OpenID/URIFetch.pm @@ -112,14 +112,10 @@ sub fetch { return $cached_response->(); } else { - my $content = $res->content; + my $content = $res->decoded_content; my $final_uri = $res->request->uri->as_string(); my $final_cache_key = "URIFetch:${prefix}:${final_uri}"; - if ($res->content_encoding && $res->content_encoding eq 'gzip') { - $content = Compress::Zlib::memGunzip($content); - } - if ($content_hook) { $content_hook->(\$content); }

Mon Aug 06 13:18:52 2012 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 22 07:33:20 2012 VLYON [...] cpan.org - Severity Normal changed to Important

Mon Apr 01 09:25:09 2013 crew [...] cs.stanford.edu - Correspondence added

ok, this is fixed in 1.15. Thanks for the patch and sorry this took so long (as it turned out this also required changes in Yadis.pm where we were also doing some manual decoding that now gets to go away. yay)

Mon Apr 01 09:25:14 2013 crew [...] cs.stanford.edu - Status changed from 'open' to 'resolved'

Mon Apr 01 09:26:02 2013 crew [...] cs.stanford.edu - Fixed in 1.15 added