| Subject: | Off-by-one bug in Xine.xs |
| Date: | Sun, 1 Jul 2012 13:55:08 +0100 |
| To: | bug-Video-Xine [...] rt.cpan.org |
| From: | Matthew King <mking [...] monnsta.net> |
In xine_play(), the ST macros used to access the optional parameters
are 1 higher than they ought to be:
Show quoted text
----BEGIN----
--- lib/Video/Xine.xs.orig 2008-06-15 16:53:28.000000000 +0000
+++ lib/Video/Xine.xs 2012-07-01 12:52:10.636139039 +0000
@@ -158,14 +158,14 @@
int start_time;
CODE:
- if (items >= 2 && SvOK(ST(2)) ) {
- start_pos = SvIV(ST(2));
+ if (items >= 2 && SvOK(ST(1)) ) {
+ start_pos = SvIV(ST(1));
}
else {
start_pos = 0;
}
- if (items >= 3 && SvOK(ST(3)) ) {
- start_time = SvIV(ST(3));
+ if (items >= 3 && SvOK(ST(2)) ) {
+ start_time = SvIV(ST(2));
}
else {
start_time = 0;
----END----
Matthew