Bug #78103 for Dist-Zilla-Plugin-Git-Remote-Check: Should be able to check current branch, as well as branch(es) specified

Thu Jun 28 13:28:28 2012 ether [...] cpan.org - Ticket created

Subject:

Should be able to check current branch, as well as branch(es) specified

Consider a release from a side branch.. which is legal if [Git::CheckFor::CorrectBranch] is not being used... [Git::Remote::Check] won't necessarily be checking the correct remote branch for unfetched changes. I'm thinking this plugin should do one of two things: - either always check the current branch (if it exists on the remote) as well as the branch(es) specified in the config, or - allow some special notation (e.g. 'checkcurrent = true') to indicate the desire to check the current branch as well as any others listed.

Sat Jul 07 10:58:12 2012 KENTNL [...] cpan.org - Correspondence added

On 2012-06-29 05:28:28, ETHER wrote:
Show quoted text

> Consider a release from a side branch.. which is legal if
> [Git::CheckFor::CorrectBranch] is not being used... [Git::Remote::Check]
> won't necessarily be checking the correct remote branch for unfetched
> changes.
>
> I'm thinking this plugin should do one of two things:
> - either always check the current branch (if it exists on the remote) as
> well as the branch(es) specified in the config, or
> - allow some special notation (e.g. 'checkcurrent = true') to indicate
> the desire to check the current branch as well as any others listed.

Trying to implement this feature, but thoughts are cloudy and I'm not 100% sure what you're asking.

With "current" branch checking things get a little messier, ie : what if you're currently not on a branch at all, but on a detached head? Then what?

And also, the notion of it checking branches, plural, is confusing, as this plugin is only designed to handle *one* branch, and if you wanted to check multiple you'd use the plugin multiple times with different names, so to check the "Current" branch instead of a specified one will require us to try work out how local branch names map to foreign ones ( not a trivial task ), as well as making a special case : Git::Remote::Check::Current , which would only check the current branch regardless of other plugin settings. ( Possibly incurring a duplicate check if you're on a branch that is explicitly configured via another plugin )

Sorry its taken me so long to respond. =)

Sat Jul 07 10:58:13 2012 The RT System itself - Status changed from 'new' to 'open'

Sat Jul 07 10:58:23 2012 KENTNL [...] cpan.org - Taken

Fri Dec 21 23:29:22 2012 ether [...] cpan.org - Correspondence added

Take a look at recent work cjm has done in DZP-Git, around version 1.122770 -- you may be able to re-use quite a lot of it.

Fri Dec 21 23:30:53 2012 ether [...] cpan.org - Correspondence added

On Fri Dec 21 20:29:22 2012, ETHER wrote: Show quoted text

> Take a look at recent work cjm has done in DZP-Git, around version > 1.122770 -- you may be able to re-use quite a lot of it.

Oh yeah, this feature would be another good use for a shared git config stash - the shared config should list the 'main' and 'release' branches, and then this feature would/could check those branches as well as the current one.

Fri Dec 21 23:32:15 2012 ether [...] cpan.org - Reference to ticket #80010 added

Thu Jul 19 12:01:01 2018 ALTREUS [...] cpan.org - Correspondence added

resurrecting this. Show quoted text

> > With "current" branch checking things get a little messier, ie : what > if you're > currently not on a branch at all, but on a detached head? Then what?

The semantics of this module seem to be "if the remote branch has changed, abort". The next level of semantics is, if someone else has done work and I've not noticed, let me deal with that first. If HEAD points to a branch then I want to release "this branch", which can be affected by other people. If it doesn't, I want to release "this commit", which can't. So we do nothing. Show quoted text

> And also, the notion of it checking branches, plural, is confusing

Indeed. All I would want the plugin to do is ask git what remote branch I am currently tracking, fetch it, and bail if I am diverged from that branch.