| CC: | lottcaskey [...] gmail.com |
| Subject: | Misnamed event: Shouldn't "error_connection" be "connection_error"? |
The event called on ESL connection failure in the "connect" method seems
to be misnamed... The current name is "error_connection", and it
probably should be "connection_error" to match the "api" method.
Also, it might be helpful to pass an error string like in the "api"
method...
$self->event('connection_error', 'Error connecting to '.$self->
{host}.':'.$self->{port}.".");
-Lott
| Subject: | perl-AnyEvent-FreeSWITCH-connection_error.patch |
diff -Naur AnyEvent-FreeSWITCH-0.01-orig/lib/AnyEvent/FreeSWITCH.pm AnyEvent-FreeSWITCH-0.01/lib/AnyEvent/FreeSWITCH.pm
--- AnyEvent-FreeSWITCH-0.01-orig/lib/AnyEvent/FreeSWITCH.pm 2012-04-10 17:46:14.000000000 -0400
+++ AnyEvent-FreeSWITCH-0.01/lib/AnyEvent/FreeSWITCH.pm 2012-06-27 02:13:42.000000000 -0400
@@ -73,7 +73,7 @@
cb => sub { $self->recv_events(); },
);
} else {
- $self->event('error_connection');
+ $self->event('connection_error', 'Error connecting to '.$self->{host}.':'.$self->{port}.".");
}
$self->{esl}->events('plain', $self->{events});