Skip Menu |

This queue is for tickets about the Perl-Tidy CPAN distribution.

Report information
The Basics
Id: 77978
Status: resolved
Priority: 0/
Queue: Perl-Tidy
People
Owner: Nobody in particular
Requestors: wyant [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 20120619
Fixed in: (no value)

History Show all quoted text
  Sat Jun 23 12:58:00 2012 wyant [...] cpan.org - Ticket created
Subject: Perl::Tidy 20120619 modifies input scalar refs.
In Perl::Tidy version 20120619, the perltidy() subroutine modifies the values of the 'source' and 'perltidyrc' arguments by chomping them. This seems like a nit-pick, but it means you now get an exception if you pass a reference to a read-only value (e.g. something created by Readonly::Scalar). It also means false positives if you determine whether code is tidy by passing scalar references to the source and destination arguments, and then comparing the results.
  Wed Jun 27 10:20:51 2012 mods [...] hank.org - Correspondence added
On Sat Jun 23 12:58:00 2012, WYANT wrote: Show quoted text
> In Perl::Tidy version 20120619, the perltidy() subroutine modifies the > values of the 'source' and 'perltidyrc' arguments by chomping them.
Just wanted to add that this is breaking our build process at this time because we have code that brings in Perl::Critic in its dependency chain and this bug is causing Perl::Critic to fail. Maybe Perl::Critic can work-around, but for now we are forcing in an old version of Perl::Tidy. The Critic bug is RT # 77977 https://rt.cpan.org/Public/Bug/Display.html?id=77977 Show quoted text
> > This seems like a nit-pick, but it means you now get an exception if you > pass a reference to a read-only value (e.g. something created by > Readonly::Scalar). > > It also means false positives if you determine whether code is tidy by > passing scalar references to the source and destination arguments, and > then comparing the results.
  Wed Jun 27 10:20:52 2012 The RT System itself - Status changed from 'new' to 'open'
  Fri Jun 29 10:48:12 2012 perltidy [...] users.sourceforge.net - Correspondence added
I'll release a corrected version in a few days after some testing. Steve
  Sun Jul 01 18:07:30 2012 perltidy [...] users.sourceforge.net - Correspondence added
Fixed in version 20120701.
  Sun Jul 01 18:07:30 2012 perltidy [...] users.sourceforge.net - Status changed from 'open' to 'resolved'