Bug #77864 for XML-LibXML: XML::LibXML broke support for references to scalars with overloaded stringification magic

Sat Jun 16 16:37:48 2012 chansen [...] cpan.org - Ticket created

XML::LibXML broke overloading and magic in 1.97. $ perl -MXML::LibXML -le 'use overload q[""] => sub { "<xml><foo /></xml>" }; my $o = bless \(my $x); print $o; XML::LibXML->new->parse_string($o);' __ chansen

Sun Jun 17 01:07:46 2012 SHLOMIF [...] cpan.org - Subject changed from (no value) to 'XML::LibXML broke support for references to scalars with overloaded stringification magic'

Sun Jun 17 01:07:46 2012 SHLOMIF [...] cpan.org - Severity Normal added

Sun Jun 17 01:07:46 2012 SHLOMIF [...] cpan.org - Broken in 1.97 added

Tue Jun 19 15:59:51 2012 SHLOMIF [...] cpan.org - Correspondence added

I should note that the following program works fine: <<<< #!/usr/bin/perl use strict; use warnings; use XML::LibXML; use overload q[""] => sub { "<xml><foo /></xml>\n" }; my $o = bless \(my $x); # my $o = bless []; print $o; print "\n"; XML::LibXML->new->parse_string("$o"); Show quoted text

>>>>

So wrapping the string-overloaded object reference in double quotes can be a temporary workaround for that. I think I know where the problem stems from and I'd like to investigate, but I think this will be done after the 2.0000 release. Regards, -- Shlomi Fish

Tue Jun 19 15:59:52 2012 The RT System itself - Status changed from 'new' to 'open'

Thu Nov 08 18:01:06 2012 chansen [...] cpan.org - Correspondence added

Attached patch restores sanity. -- chansen

Subject:

LibXML.xs.patch

--- LibXML.xs.orig 2012-10-13 12:39:38.000000000 +0200 +++ LibXML.xs 2012-11-08 23:50:04.000000000 +0100 @@ -1599,7 +1599,7 @@ PREINIT: char * directory = NULL; STRLEN len; - char * ptr; + const char * ptr; HV * real_obj; int well_formed; int valid; @@ -1615,11 +1615,12 @@ } } /* If string is a reference to a string - dereference it. - * See: https://rt.cpan.org/Ticket/Display.html?id=64051 . */ - if (SvROK(string)) { + * See: https://rt.cpan.org/Ticket/Display.html?id=64051 (broke it) + * https://rt.cpan.org/Ticket/Display.html?id=77864 (fixed it) */ + if (SvROK(string) && !SvOBJECT(SvRV(string))) { string = SvRV(string); } - ptr = SvPV(string, len); + ptr = SvPV_const(string, len); if (len <= 0) { croak("Empty string\n"); XSRETURN_UNDEF; @@ -1628,7 +1629,7 @@ RETVAL = &PL_sv_undef; INIT_ERROR_HANDLER; { - xmlParserCtxtPtr ctxt = xmlCreateMemoryParserCtxt((const char*)ptr, len); + xmlParserCtxtPtr ctxt = xmlCreateMemoryParserCtxt(ptr, len); if (ctxt == NULL) { CLEANUP_ERROR_HANDLER; REPORT_ERROR(1);

Thu Nov 08 23:45:57 2012 SHLOMIF [...] cpan.org - Correspondence added

On Thu Nov 08 18:01:06 2012, CHANSEN wrote: Show quoted text

> Attached patch restores sanity. >

Thanks for the patch (and the report). This is now fixed in XML-LibXML-2.0012 which was just uploaded to CPAN. Sorry it took me so long. Regards, -- Shlomi Fish Show quoted text

> -- > chansen

Thu Nov 08 23:45:59 2012 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'