Bug #77850 for Dist-Zilla-Plugin-Git: [Git::Check] and [Git::GatherDir] work at cross-purposes

Fri Jun 15 18:34:35 2012 ether [...] cpan.org - Ticket created

Subject:

[Git::Check] and [Git::GatherDir] work at cross-purposes

The purpose of [Git::GatherDir] is to omit filegathering untracked files... yet, [Git::Check] doesn't permit releasing these anyway! So it still isn't possible to release while having untracked files in the repository, even if they aren't gathered. It would make more sense to have an option in [Git::Check] to ignore untracked files (and therefore only check tracked files with uncommitted changes). Right now the only recourse is to disable [Git::Check] entirely. (Potentially it could check if [Git::GatherDir] is present, and configure itself automatically, but that seems a bit too magical to me.)

Sat Jun 16 04:11:14 2012 jquelin [...] cpan.org - Correspondence added

On Fri Jun 15 18:34:35 2012, ETHER wrote: Show quoted text

> The purpose of [Git::GatherDir] is to omit filegathering untracked > files... yet, [Git::Check] doesn't permit releasing these anyway! So it > still isn't possible to release while having untracked files in the > repository, even if they aren't gathered.

i don't really understand why you would want to use git::check when using git::gatherdir. as you said, both are complementary / opposite. indeed, what would be the behaviour of git::check with git::gatherdir in use? so either use git::gatherdir but not git::check, or use gatherdir (not git::gatherdir) and git::check. note that @git bundle doesn't use git::gatherdir.

Sat Jun 16 04:11:16 2012 The RT System itself - Status changed from 'new' to 'open'

Sat Jun 16 12:09:52 2012 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #77850] [Git::Check] and [Git::GatherDir] work at cross-purposes
Date:	Sat, 16 Jun 2012 09:09:41 -0700
To:	Jerome Quelin via RT <bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Sat, Jun 16, 2012 at 04:11:16AM -0400, Jerome Quelin via RT wrote: Show quoted text

> i don't really understand why you would want to use git::check when > using git::gatherdir. as you said, both are complementary / opposite. > > indeed, what would be the behaviour of git::check with git::gatherdir in > use?

Git::Check does two things: - checks for files that are known to git, but have uncommitted changes - checks for files that are not known to git at all The first of these two checks is still quite valuable in the presence of Git::GatherDir, as it means uncommitted changes will be in the release. Therefore, it would be useful to be able to selectively enable/disable these two checks individually. Show quoted text

> so either use git::gatherdir but not git::check, or use gatherdir (not > git::gatherdir) and git::check.

As described above, removing the use of Git::Check while using Git::GatherDir removes a useful sanity check at release time.

Mon Jul 02 18:58:24 2012 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #77850] AutoReply: [Git::Check] and [Git::GatherDir] work at cross-purposes
Date:	Mon, 2 Jul 2012 15:58:09 -0700
To:	Bugs in Dist-Zilla-Plugin-Git via RT <bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

I noticed that doy's patch at https://github.com/doy/dist-zilla-plugin-git/commit/f3a2717bf5c9c0333a287b9d046deaaff666dc77 (not sure if there is a pull request) ...seeks to solve the same problem.

Thu Oct 18 00:11:25 2012 cjm [...] cpan.org - Fixed in 1.122770 added

Thu Oct 18 00:11:25 2012 cjm [...] cpan.org - Correspondence added

https://github.com/madsen/dist-zilla-plugin-git/commit/0f10e8813adce8d5f02e737171f1b6b082906699 adds an untracked_files option to Git::Check. Released as 1.122770.

Thu Oct 18 00:11:26 2012 cjm [...] cpan.org - Status changed from 'open' to 'resolved'