Skip Menu |

This queue is for tickets about the Data-FormValidator CPAN distribution.

Maintainer(s)' notes

This is the bug queue for Data::FormValidator.

Report information
The Basics
Id: 77765
Status: open
Priority: 0/
Queue: Data-FormValidator
People
Owner: MARKSTOS [...] cpan.org
Requestors: slanning [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 4.70
Fixed in: (no value)

History Show all quoted text
  Mon Jun 11 17:23:40 2012 slanning [...] cpan.org - Ticket created
Subject: don't set $^W = 0
In lib/Data/FormValidator/Results.pm , sub _arrayify , there is: - $^W = 0; # turn off warnings about undef This unexpectedly turns off warnings for any code using Data::FormValidator , if invoked with "perl -w". Localizing it will work as well, without turning off warnings: + local $^W = 0; # turn off warnings about undef
  Tue Jun 12 13:19:54 2012 MARKSTOS [...] cpan.org - Taken
  Tue Jun 12 13:20:25 2012 MARKSTOS [...] cpan.org - Correspondence added
You are correct about the appropriate use of 'local' here. Thanks for the report and the patch.
  Tue Jun 12 13:20:28 2012 The RT System itself - Status changed from 'new' to 'open'
  Wed Jan 25 22:24:13 2017 DFARRELL [...] cpan.org - Correspondence added
On Mon Jun 11 17:23:40 2012, SLANNING wrote: Show quoted text
> In lib/Data/FormValidator/Results.pm , sub _arrayify , > there is: > > - $^W = 0; # turn off warnings about undef > > This unexpectedly turns off warnings for any code using > Data::FormValidator , if invoked with "perl -w". > Localizing it will work as well, without turning off warnings: > > + local $^W = 0; # turn off warnings about undef
Thanks for this, I've applied it to the fork https://github.com/dnmfarrell/Data-FormValidator/commit/5919c718b430664e901280fbc331b9c134a0dfaa